feat: Support for XLS-0066 Lending Protocol #1259
Conversation
src/containers/shared/components/Transaction/LoanBrokerSet/Simple.tsx
Outdated
Show resolved
Hide resolved
src/containers/shared/components/Transaction/LoanBrokerSet/Simple.tsx
Outdated
Show resolved
Hide resolved
…plorer into lending-protocol-basic
|
@kuan121 the PR is ready to next round of reviews. Thanks for great catches in the last round! I have updated the screenshots and marked comments as resolved (feel free to unresolve if needed, I just marked them for my own sanity checks) |
| digits = 2, | ||
| cutoff = 0.01, |
There was a problem hiding this comment.
shouldn't cutoff be derived from digits?
There was a problem hiding this comment.
It wouldn't harm to have both, since user might want to see 0.99998 with 0.01 cutoff for example
| const coverRateMinimum = fields.CoverRateMinimum || 0 | ||
|
|
||
| // CoverRateMinimum is in 1/10th basis points, so divide by 100000 | ||
| const requiredCover = debtTotal * (coverRateMinimum / 100000) |
There was a problem hiding this comment.
I saw consts defined for the 1/10th basis points somewhere else, can we reuse that here
There was a problem hiding this comment.
The other ones were used to show percentage, so that variable is 1000, not 100000
| * - IOU: { "currency": "USD", "issuer": "rXXX..." } | ||
| * - MPT: { "mpt_issuance_id": "000000..." } | ||
| */ | ||
| export function formatAsset(asset: any): Asset { |
There was a problem hiding this comment.
was this moved from somewhere else? I believe this logic is already in xrpl.js if we could reuse that
There was a problem hiding this comment.
Could be a future improvements, since we use isMPT boolean in some rendering functions, so we cannot directly use xrpl.js without fixing all of them
achowdhry-ripple
left a comment
achowdhry-ripple
left a comment
There was a problem hiding this comment.
small nits but overall looks good!
High Level Overview of Change
Add support for XLS-0066 Lending Protocol.
Context of Change
The specification can be found here: XRPLF/XRPL-Standards#240
The cpp implementation is available here: XRPLF/rippled#5270
Type of Change
Before / After
LoanBrokerSet
(Special case for
DebtMaximum:when zero, the UI will display
No Limit)LoanBrokerDelete
(This one is failing due to Loan term had not expired, but all fields are there):
LoanBrokerCoverDeposit
LoanBrokerCoverWithdraw
LoanBrokerCoverCallback
(There a special case for
Amountfield when it is set to zero:which has been handled by the code)
LoanSet
LoanPay
LoanManage (with Flags displayed in Detailed tab)
LoanDelete
(This one is failing due to Loan term had not expired, but all fields are there)
MPT as underlying asset is displayed correctly
Test Plan