Fix: Display scaled MPToken balance #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdp2121
approved these changes
Nov 12, 2025
kuan121
reviewed
Nov 12, 2025
| // MPT balance must be scaled by the appropriate asset_scale exponent. | ||
| // Please refer to this documentation for more details: | ||
| // https://xrpl.org/docs/references/protocol/transactions/types/mptokenissuancecreate#mptokenissuancecreate-fields | ||
| balance: mpToken.mptAmount * 10 ** -(mptIssuance?.assetScale ?? 0), |
Contributor
There was a problem hiding this comment.
- We need to apply this to all MPT amounts. The outstandingAmt field is used in IssuedMPTs.tsx#L62.
- Can we reuse convertScaledPrice to avoid duplicating the scaling logic and related comments in multiple places?
Contributor
Author
There was a problem hiding this comment.
Ok. These concerns have been addressed in this commit: d8471d7
Contributor
There was a problem hiding this comment.
Thanks. Can you remove the unnecessary comments?
…e Account Page refactor: use the convertScaledPrice method to scale the MPT balance values
kuan121
reviewed
Nov 12, 2025
Comment on lines
94
to
97
| // MPT balance must be scaled by the appropriate asset_scale exponent. | ||
| // Please refer to this documentation for more details: | ||
| // https://xrpl.org/docs/references/protocol/transactions/types/mptokenissuancecreate#mptokenissuancecreate-fields | ||
| // balance: mpToken.mptAmount * 10 ** -(mptIssuance?.assetScale ?? 0), |
Contributor
There was a problem hiding this comment.
Let's remove these comments
kuan121
approved these changes
Nov 12, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The MPToken balances are not scaled appropriately. This commit fixes this issue in the
HeldMPTssection of an AccountPage. Furthermore, some of the legacy jest test matchers have been updated to pass the CI requirements.Type of Change
Codebase Modernization
Test Plan
Existing test has been updated to validate the scaled asset price scenario.