ZIR-363: Add circuit location statistics for recursion predicates #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
shkoo
force-pushed
the
nils/predicate-op-stats
branch
from
15c5a81 to
9548a2b
Compare
shkoo
force-pushed
the
nils/predicate-op-stats
branch
3 times, most recently
from
2cf6a48 to
9b67fb5
Compare
* Overhaul EDSL location handling; we now generate mlir Locations directly instead of keeping our own SourceLoc structure, and it's relatively easy to add additional context to component construction using ScopedSourceLoc. * Expand --op-stats flag to work on `gen_predicates`; this outputs `...-opstats.txt` files in the output directory for each predicate processed. * --op-stats on `gen_predicates` also outputs encoded cycle counts in `...-encoded-cycles.txt` * Added a bunch more source annotations to get better granularity for recursion predicates.
shkoo
force-pushed
the
nils/predicate-op-stats
branch
from
9b67fb5 to
b8170f0
Compare
shkoo
force-pushed
the
nils/predicate-op-stats
branch
from
a764021 to
9b7da70
Compare
jacobdweightman
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhaul EDSL location handling; we now generate mlir Locations directly instead of keeping our own SourceLoc structure, and it's relatively easy to add additional context to component construction using ScopedSourceLoc.
Expand --op-stats flag to work on
gen_predicates; this outputs...-opstats.txtfiles in the output directory for each predicate processed.Add --op-stats-flat-cost flag to count each instruction the same. (This is still not the same as the number of cycles in the ZKR, since the statistics are collected before encoding)
Added a bunch more source annotations to get better granularity for recursion predicates.