regression: Smart construction/configuration of TARGETS
#1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes:
1. Default target list is easier to read and to reconfigure
by splitting target bases and code models.
2. TARGETS is now configurable through external environment variable
(not just as a make argument), which makes TARGETS consistent with
RUNTESTFLAGS.
Because `TARGETS = ...` is used inside the Makefile, we could configure
targets to perform regression tests with `make report TARGETS='...'` but
not `TARGETS='...' make report`. This semantics is inconsistent with e.g.
RUNTESTFLAGS as shown in README.md.
This commit now uses `?=` to respect environment variable TARGETS
given from outside, making `TARGETS='...' make report` usable.
Also, this commit changes how default target list is constructed.
It splits target bases and code models and each is reconfigurable through
make arguments (like `make report TARGET_CODE_MODELS=medlow`).
Note that TARGET_BASES and TARGET_CODE_MODELS are chosen so that no
submodules use those Make variables and are ignored when the variable
`TARGETS` is explicitly configured.
|
LGTM, it make sense, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes:
TARGETSis now configurable through external environment variable (not just as a make argument), which makesTARGETSconsistent withRUNTESTFLAGS.Because
TARGETS = ...is used inside the Makefile, we could configure targets to perform regression tests withmake report TARGETS='...'but notTARGETS='...' make report. This semantics is inconsistent with e.g. RUNTESTFLAGS as shown in README.md.This commit now uses
?=to respect environment variableTARGETSgiven from outside, makingTARGETS='...' make reportusable.Also, this commit changes how default target list is constructed.
It splits target bases and code models and each is reconfigurable through make arguments (like
make report TARGET_CODE_MODELS=medlow).Note that
TARGET_BASESandTARGET_CODE_MODELSare chosen so that no submodules use those Make variables and are ignored when the variableTARGETSis explicitly configured.