Skip to content

Remove more left-over definitions #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: riscv-port-branch
Choose a base branch
from
Open

Remove more left-over definitions #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcaab1d
Remove leftover delayed_value methods
andreas-schwab Sep 22, 2021
fff844e
Remove left-over definition of set_last_Java_fp
andreas-schwab Sep 23, 2021
b28ae32
Remove left-over NativeInstruction::test methods
andreas-schwab Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/hotspot/cpu/riscv64/assembler_riscv64.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2830,13 +2830,6 @@ enum Nf {
Assembler(CodeBuffer* code) : AbstractAssembler(code) {
}

virtual RegisterOrConstant delayed_value_impl(intptr_t* delayed_value_addr,
Register tmp,
int offset) {
ShouldNotCallThis();
return RegisterOrConstant();
}

// Stack overflow checking
virtual void bang_stack_with_offset(int offset) { Unimplemented(); }

Expand Down
6 changes: 2 additions & 4 deletions src/hotspot/cpu/riscv64/javaFrameAnchor_riscv64.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,8 @@

public:

void set_last_Java_sp(intptr_t* java_sp) { _last_Java_sp = java_sp; OrderAccess::release(); }
void set_last_Java_sp(intptr_t* java_sp) { _last_Java_sp = java_sp; OrderAccess::release(); }

intptr_t* last_Java_fp(void) { return _last_Java_fp; }
// Assert (last_Java_sp == NULL || fp == NULL)
void set_last_Java_fp(intptr_t* java_fp) { OrderAccess::release(); _last_Java_fp = java_fp; }
intptr_t* last_Java_fp(void) { return _last_Java_fp; }

#endif // CPU_RISCV64_JAVAFRAMEANCHOR_RISCV64_HPP
6 changes: 0 additions & 6 deletions src/hotspot/cpu/riscv64/macroAssembler_riscv64.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,12 +366,6 @@ class MacroAssembler: public Assembler {

void should_not_reach_here(bool compressed = true) { stop("should not reach here", compressed); }

virtual RegisterOrConstant delayed_value_impl(intptr_t* delayed_value_addr,
Register tmp,
int offset) {
return RegisterOrConstant(tmp);
}

static address target_addr_for_insn(address insn_addr);

// Required platform-specific helpers for Label::patch_instructions.
Expand Down
3 changes: 0 additions & 3 deletions src/hotspot/cpu/riscv64/nativeInst_riscv64.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,9 +506,6 @@ class NativeJump: public NativeInstruction {

void verify();

// Unit testing stuff
static void test() {}

// Insertion of native jump instruction
static void insert(address code_pos, address entry);
// MT-safe insertion of native jump at verified method entry
Expand Down