This repository was archived by the owner on Sep 2, 2025. It is now read-only.
force-amo: allowing AMOxxx instructions for riscv32imc#57
Open
romancardenas wants to merge 1 commit intoriscv-rust:masterfrom
Open
force-amo: allowing AMOxxx instructions for riscv32imc#57romancardenas wants to merge 1 commit intoriscv-rust:masterfrom
romancardenas wants to merge 1 commit intoriscv-rust:masterfrom
Conversation
almindor
approved these changes
Oct 31, 2023
Collaborator
almindor
left a comment
almindor
left a comment
There was a problem hiding this comment.
I also agree with the imc/imac cleanup it's been a mess
Member
Author
|
This PR solves #56 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The E310X atomic support is limited, as it only allows us to use AMO instructions, while LR/SC instructions provoke an exception. Thus, we need to provide support for
riscv32imc-unknown-none-elfto use LR/SC instructions viaportable-atomic. However, currently you either use emulation of all the atomic instructions or a faulty atomic target.This PR uses a new version of
portable-atomic, which added a new feature to use real AMO instructions forriscv32imc-unknown-none-elftargets while emulating LR/SC instructions. This is particularly well-suited for the E310x microcontroller. Note that the MSRV is now 1.72.As a side note: In my opinion, this microcontroller does not deserve to be called a
riscv32imactarget. We should stop supportingriscv32imacand clearly document this particularity, asking users to always useriscv32imcwithportable-atomicandforce-amowhen needed.