Skip to content

Fix Insecure Deserialization Vulnerability in toObject Method #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Insecure Deserialization Vulnerability in toObject Method #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
328c2e7
Fix Insecure Deserialization Vulnerability in toObject Method
th555555 May 20, 2025
f37b913
Fix HTTP Header Injection Vulnerability in BPMN Export Feature
th555555 May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...p-jodconverter/src/main/java/net/risesoft/service/cache/impl/CacheServiceRocksDBImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,8 @@ private byte[] toByteArray(Object obj) throws IOException {
private Object toObject(byte[] bytes) throws IOException, ClassNotFoundException {
Object obj;
ByteArrayInputStream bis = new ByteArrayInputStream(bytes);
ObjectInputStream ois = new ObjectInputStream(bis);
ValidatingObjectInputStream ois = new ValidatingObjectInputStream(bis); {
ois.accept(LinkedList.class, LogMutation.class, HashMap.class, String.class);
obj = ois.readObject();
ois.close();
bis.close();
Expand Down
17 changes: 13 additions & 4 deletions ...-webapp-processadmin/src/main/java/net/risesoft/controller/ProcessModelVueController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,22 @@ public Y9Result<String> deployModel(@RequestParam @NotBlank String modelId) {
public void exportModel(@RequestParam @NotBlank String modelId, HttpServletResponse response) {
try {
Model model = modelService.getModel(modelId);
if (model == null) {
response.sendError(HttpServletResponse.SC_NOT_FOUND, "Model not found");
return;
}

byte[] bpmnBytes = modelService.getBpmnXML(model);

ByteArrayInputStream in = new ByteArrayInputStream(bpmnBytes);
String filename = model.getKey() + ".bpmn20.xml";
response.setHeader("Content-Disposition", "attachment; filename=" + filename);
IOUtils.copy(in, response.getOutputStream());
response.flushBuffer();
response.setCharacterEncoding("UTF-8");
response.setContentType("application/octet-stream");
response.setHeader("Content-Disposition", "attachment; filename=" + URLEncoder.encode(filename, "UTF-8"));

try (ByteArrayInputStream in = new ByteArrayInputStream(bpmnBytes)) {
IOUtils.copy(in, response.getOutputStream());
response.flushBuffer();
}
} catch (Exception e) {
LOGGER.error("导出模型失败,modelId:{} 异常：{}", modelId, e.getMessage());
}
Expand Down