Skip to content

Conversation

@BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao requested a review from a team as a code owner October 16, 2025 08:53
@BugenZhao BugenZhao requested review from wenym1 and removed request for a team October 16, 2025 08:53
@github-actions github-actions bot added the type/refactor Type: Refactoring. label Oct 16, 2025
Copy link
Member Author

BugenZhao commented Oct 16, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the codebase to remove dependencies on the lru crate by replacing LRU cache implementations with simpler alternatives. The main change is replacing an LRU cache-based SetStmts implementation with an IndexMap-based solution, and consolidating indexmap dependency versions across the workspace.

Key changes:

  • Replaced LruCache with IndexMap in the simulation test client's SetStmts struct
  • Removed the lru dependency from production code crates (stream, common)
  • Standardized indexmap dependency version across workspace crates

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/tests/simulation/src/client.rs Replaced LruCache with IndexMap for storing SET statements, simplified iterator implementation
src/tests/simulation/Cargo.toml Replaced lru dependency with indexmap
src/stream/src/executor/temporal_join.rs Updated hasher import from lru::DefaultHasher to risingwave_common::lru::RandomState
src/stream/Cargo.toml Removed lru dependency from stream crate
src/meta/Cargo.toml Updated indexmap to use workspace version
src/connector/Cargo.toml Updated indexmap to use workspace version
src/common/Cargo.toml Moved lru dependency from main dependencies to dev-dependencies
Cargo.toml Defined indexmap workspace dependency with version 2 and serde feature

Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Base automatically changed from bz/divine-constrictor to main October 16, 2025 10:13
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May merge after #23473

Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao added this pull request to the merge queue Oct 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2025
@BugenZhao BugenZhao changed the title refactor: remove some deps on lru refactor:  remove some deps on lru Oct 22, 2025
@BugenZhao BugenZhao added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit 47b9dd2 Oct 22, 2025
36 checks passed
@BugenZhao BugenZhao deleted the bz/sorry-tick branch October 22, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/refactor Type: Refactoring.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants