-
Notifications
You must be signed in to change notification settings - Fork 710
refactor: remove some deps on lru
#23489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Bugen Zhao <[email protected]>
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the codebase to remove dependencies on the lru crate by replacing LRU cache implementations with simpler alternatives. The main change is replacing an LRU cache-based SetStmts implementation with an IndexMap-based solution, and consolidating indexmap dependency versions across the workspace.
Key changes:
- Replaced
LruCachewithIndexMapin the simulation test client'sSetStmtsstruct - Removed the
lrudependency from production code crates (stream,common) - Standardized
indexmapdependency version across workspace crates
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/simulation/src/client.rs | Replaced LruCache with IndexMap for storing SET statements, simplified iterator implementation |
| src/tests/simulation/Cargo.toml | Replaced lru dependency with indexmap |
| src/stream/src/executor/temporal_join.rs | Updated hasher import from lru::DefaultHasher to risingwave_common::lru::RandomState |
| src/stream/Cargo.toml | Removed lru dependency from stream crate |
| src/meta/Cargo.toml | Updated indexmap to use workspace version |
| src/connector/Cargo.toml | Updated indexmap to use workspace version |
| src/common/Cargo.toml | Moved lru dependency from main dependencies to dev-dependencies |
| Cargo.toml | Defined indexmap workspace dependency with version 2 and serde feature |
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
wenym1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May merge after #23473
3ffa483 to
74a8ba6
Compare
74a8ba6 to
2a2978b
Compare
Signed-off-by: Bugen Zhao <[email protected]>
2a2978b to
7cb92fb
Compare
lrulru

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title.
Checklist
Documentation
Release note