Skip to content

Conversation

@TennyZhuang
Copy link
Contributor

What's changed and what's your intention?

As title.

Please note that only memory used in the hash map itself is counted, blocking on rust-lang/rust#77438

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@TennyZhuang TennyZhuang requested review from skyzh, xxchan and yuhao-su June 7, 2022 03:07
@github-actions github-actions bot added the type/feature Type: New feature. label Jun 7, 2022
Signed-off-by: TennyZhuang <[email protected]>
Signed-off-by: TennyZhuang <[email protected]>
@TennyZhuang TennyZhuang enabled auto-merge (squash) June 7, 2022 05:46
Signed-off-by: TennyZhuang <[email protected]>
Signed-off-by: TennyZhuang <[email protected]>
@TennyZhuang TennyZhuang merged commit 82aeacc into main Jun 7, 2022
@TennyZhuang TennyZhuang deleted the feat/allocator-hash-join branch June 7, 2022 06:49
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #3020 (c151584) into main (87b9397) will decrease coverage by 0.05%.
The diff coverage is 35.82%.

@@            Coverage Diff             @@
##             main    #3020      +/-   ##
==========================================
- Coverage   73.16%   73.10%   -0.06%     
==========================================
  Files         724      725       +1     
  Lines       97255    97387     +132     
==========================================
+ Hits        71154    71199      +45     
- Misses      26101    26188      +87     
Flag Coverage Δ
rust 73.10% <35.82%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/lib.rs 100.00% <ø> (ø)
src/stream/src/lib.rs 100.00% <ø> (ø)
src/utils/stats_alloc/src/lib.rs 30.43% <30.43%> (ø)
src/common/src/collection/evictable.rs 72.58% <66.66%> (-1.01%) ⬇️
src/stream/src/executor/managed_state/join/mod.rs 73.07% <70.00%> (-0.49%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BugenZhao BugenZhao mentioned this pull request Oct 16, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants