WIP: Whole document review #169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpugin
reviewed
Jan 7, 2026
I normalized it to "and" since that seems to be what Brook & Gould called it.
Collaborator
|
We're going with |
Contributor
Author
|
🤷 We could go either way. I chose |
lpugin
reviewed
Jan 7, 2026
Co-authored-by: Laurent Pugin <lxpugin@gmail.com>
Collaborator
|
I'd go with |
Co-authored-by: Laurent Pugin <lxpugin@gmail.com>
Also tidy up the chord prose.
lpugin
reviewed
Jan 9, 2026
| <p> | ||
| Accidentals MUST be interpreted by their written value, and MUST NOT be interpreted by their values | ||
| relative to a preceding accidental. | ||
| A note cannot be altered by the same accidental more than once within the same bar. The |
Contributor
There was a problem hiding this comment.
I would drop it. The following sentence is better and enough.
Co-authored-by: Laurent Pugin <lxpugin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here can be reviewed but the whole PR is a WIP as I do other passes through the document.