Announcement Preview and Link Button #1139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZZwatermelon
requested changes
Oct 28, 2025
server/src/db/migrations/20251016175110_announcement-link-columns.ts
Outdated
Show resolved
Hide resolved
cowsed
reviewed
Nov 2, 2025
Contributor
cowsed
left a comment
cowsed
left a comment
There was a problem hiding this comment.
I like the default to https, thats really nice. just the one thing about the switch and i think this is good
| const navigate = useNavigate(); | ||
|
|
||
|
|
||
| const [showLinkFields, setShowLinkFields] = useState(!!announcementDraft.linkUrl || !!announcementDraft.linkText); |
Contributor
There was a problem hiding this comment.
When testing this, it seems like the default value of this isnt getting calculated just right. If i add a link and link text to an announcement, then save and close it, then reopen it, the Link Button switch is set to off. If i turn it on manually it shows the saved fields just fine though
Contributor
Author
There was a problem hiding this comment.
I recently pushed a commit (64e5ce4) to remedy this. The useEffect looks clunky to me but I could be overthinking it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1062
Closes: #1054