Fix Warnings #1152
Open
Fix Warnings #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SierraTran
reviewed
Nov 3, 2025
| import React, { useState } from "react"; | ||
| import Page from "../../Page"; | ||
| import Explainer from "./Explainer"; | ||
| import { gql, useQuery } from "@apollo/client"; |
There was a problem hiding this comment.
I'm getting a warning that says 'gql' is defined but never used. Allowed unused vars must match /^_/u from the frontend build. Was this left in on purpose for something in the future?
There was a problem hiding this comment.
Oops that as an oversight on my part, thanks for catching that. fixed now.
I think now all the remaining ones are larger things that should be addressed separately but lmk if you think differently.
ZZwatermelon
reviewed
Nov 3, 2025
|
|
||
| const [name, setName] = useState(""); | ||
| const [imageUrl, setImageUrl] = useState(""); | ||
| const [imageUrl, _] = useState(""); |
There was a problem hiding this comment.
It feels silly to use useState here, no?
There was a problem hiding this comment.
excellent point, just gonna use an empty string
ZZwatermelon
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Periodic scan through and fix of general warnings. Mostly