Skip to content

fix: add rate limiting to auth endpoints #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saurabhhhcodes wants to merge 2 commits into from
Closed

fix: add rate limiting to auth endpoints #3398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca3702a
chore: stop tracking local editor artifacts
Jul 5, 2026
96a30a4
fix: rate limit auth endpoints
Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ node_modules/
dist/
.vercel
*.local
.npm-cache/
.npm/
.vscode/
!.vscode/extensions.json
Comment on lines +27 to +30

@coderabbitai coderabbitai Bot Jul 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
git check-ignore -v .vscode/extensions.json

Repository: ritesh-1918/HELPDESK.AI

Length of output: 208

Rework the .vscode ignore rule

Ignoring the directory itself prevents !.vscode/extensions.json from bringing that file back in. Use .vscode/* instead, or unignore .vscode/ before the exception.

Suggested fix 
-.vscode/
+.vscode/*
 !.vscode/extensions.json
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.npm-cache/
.npm/
.vscode/
!.vscode/extensions.json
.npm-cache/
.npm/
.vscode/*
!.vscode/extensions.json
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.gitignore around lines 27 - 30, The .gitignore rule for .vscode currently
ignores the directory itself, which blocks the later exception for
extensions.json. Update the ignore pattern to target the contents of .vscode
instead, or explicitly unignore the .vscode directory before the
!.vscode/extensions.json exception so the file can be tracked correctly.


# Docs / Artifacts
docs/helpdesk*.pdf
Expand Down
Empty file removed .npm-cache/_update-notifier-last-checked
View file
Open in desktop
Empty file.
6 changes: 0 additions & 6 deletions .vscode/settings.json
View file
Open in desktop

This file was deleted.

7 changes: 4 additions & 3 deletions backend/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,7 +1151,8 @@ class SignupBody(BaseModel):
company: str | None = None

@app.post("/auth/login")
async def auth_login(body: LoginBody, response: Response):
@limiter.limit("10/minute")
async def auth_login(body: LoginBody, request: Request, response: Response):
if not supabase:
raise HTTPException(status_code=503, detail="Database connection offline")
try:
Expand All @@ -1171,7 +1172,8 @@ async def auth_login(body: LoginBody, response: Response):
return {"user": user_payload, "message": "Session cookies set"}

@app.post("/auth/signup")
async def auth_signup(body: SignupBody, response: Response):
@limiter.limit("5/minute")
async def auth_signup(body: SignupBody, request: Request, response: Response):
if not supabase:
raise HTTPException(status_code=503, detail="Database connection offline")
metadata = {}
Expand Down Expand Up @@ -1208,4 +1210,3 @@ async def auth_logout(response: Response):
@app.get("/auth/me")
async def auth_me(user: dict = Depends(get_current_user)):
return {"user": user}

Loading