fix(rivetkit): call importNodeDependencies() in drizzle db() to fix migration crypto error

[abcxff]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[abcxff]

• fix(rivetkit): call importNodeDependencies() in drizzle db() to fix migration crypto error #4963 👈 (View in Graphite)
• fix(rivetkit): wrap onMigrate in savepoints #4960 : 1 other dependent PR (#4962 )
• fix(pegboard): align drain grace defaults with stop threshold #4958 : 1 other dependent PR (#4966 )
• fix(rivetkit): preserve bridge error messages #4959
• fix(rivetkit): fire abort signal on shutdown finalize #4957
• fix(rivetkit): use startup kv preload #4956
• fix(client): flatten skipReadyWait option #4955
• ci(publish): add manual preview publish flow #4954
• fix(depot): add ltx decode diagnostics #4953
• fix(universaldb): preserve plain set values #4952
• fix(universaldb): align versionstamp operand encoding #4951
• fix(rivetkit): export database provider types #4950
• wip: kitchen sink agentic loop finish #4949
• chore(rivetkit): note duplicate admission logic #4948
• test(rivetkit): cover bypass fetch header forwarding #4947
• feat(kitchen-sink): add actor probe controls #4946
• fix(gateway): split actor response wait errors #4945
• fix(guard): handle bypass preflight before query parse #4944
• feat(kitchen-sink): add mock agent event log copy #4943
• fix(kitchen-sink): default mock agent to local endpoint #4942
• test(rivetkit): enable driver lifecycle regressions #4941
• test(rivetkit): verify cached websocket db refs exceed grace #4940
• fix(rivetkit-core): keep sleeping actors reachable during grace #4939
• test(rivetkit): cover async websocket close db access #4938
• fix(rivetkit): keep actors awake until keepAwake work finishes #4937
• fix(rivetkit): persist native onSleep state on errors #4936
• fix(rivetkit-core): allow dispatch during sleep grace #4935
• fix(rivetkit): make duplicate sleep requests idempotent #4934
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review

Summary

This PR adds a call to importNodeDependencies() at the top of the db() function in rivetkit-typescript/packages/rivetkit/src/db/drizzle.ts. The intent is to ensure the Node.js crypto module is loaded before getNodeCrypto() is called during migrations (which would otherwise throw with a confusing "Node crypto module not loaded" error).

The fix is correct and minimal. A few observations worth considering:

---

Issues

1. importNodeDependencies() is called at factory-definition time, not at migration time

db() returns a DatabaseProvider object — it does not run migrations or access crypto itself. The actual getNodeCrypto() call happens inside runMigrations(), which is invoked from the onMigrate callback on the returned provider object. This means importNodeDependencies() currently runs synchronously when the user calls db({ migrations: ... }) to define their database provider (module load time), not when the migration executes.

This is effectively fine in Node.js (where the function is cheap and idempotent), but it means errors from importNodeDependencies() surface at definition time rather than at migration time. If this provider is used in an environment where Node modules are unavailable (e.g. wasm/edge), calling db() will now throw immediately during module evaluation rather than failing gracefully at migration time.

Consider whether importNodeDependencies() should be deferred to createClient or onMigrate instead, so non-Node runtimes can still use the db() factory (even if they'll fail on onMigrate).

2. The PR description is not filled out

The PR body uses the default template with no description, no test plan, and no checklist items checked. Even for a small fix, it should describe the root cause (calling db() before registry.start() or any other importNodeDependencies() call site) and how it was tested.

3. [slop] prefix in the commit message and branch name

The commit message headline is [slop]fix(rivetkit): call importNodeDependencies() in drizzle db() to…. The [slop] prefix is non-standard and violates the project's conventional commit style. CLAUDE.md requires git commit -m "chore(my-pkg): foo bar" with no extra prefixes.

---

Observations (non-blocking)

importNodeDependencies() is already idempotent (hasImportedDependencies guard in node.ts), so calling it from db() adds no overhead on repeated calls. The fix is safe.

No other db()-like factory function needs this change. The only other file in src/db/ is mod.ts (re-exports), and the only other file using getNodeCrypto outside drizzle.ts is node.ts itself. The scope is correct.

The fix aligns with the CLAUDE.md "Fail-By-Default Runtime" principle — surfacing the missing dependency early rather than letting it crash deep inside migration logic.

---

Verdict

The code change itself is correct and minimal. The main concerns are:

1. Consider deferring importNodeDependencies() to onMigrate so wasm/edge runtimes can still construct a db() provider without immediately throwing.
2. The PR description and checklist need to be filled in.
3. The [slop] commit message prefix should be removed before merge.

x

[NathanFlurry]

#4971