Convert project to NetSDK format #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g capabilities note: PowerShell packages are in fact NuGet packages
mnivet
commented
Jan 10, 2020
| # Visual Studio 2013 | ||
| VisualStudioVersion = 12.0.20623.1 VSUPREVIEW | ||
| # Visual Studio Version 16 | ||
| VisualStudioVersion = 16.0.29613.14 |
Author
There was a problem hiding this comment.
Upgrading the solution to VS2019 was not mandatory, but keeping it declaring VS2013 was erroneous, since we need at least VS2017 to build a csproj at NetSDK format...
So we may roll back to declare VS2017 (15) instead of VS2019 if you want, but I have supposed that in 2020 everybody has already move on VS2019 or VSCode (which works with this new Net SDK format and don't care of this version number in the sln file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New NetSDK format for csproj, supported since VS2017, provides native NuGet packaging capabilities, which should help to produce a valid PowerShell package later since PowerShell packages are just NuGet packages with conventions specific to PowerShell
This PR is not really adding the support of packaging the dll as a PowerShell package.
It's just a preparation step for that.
But this PR is not limited to this, it also fix the reference issue discuss in issue #1 thanks to the comment of martinisoft1, and use more reliable references to System.*.WindowsRuntime with the help of NuGet