Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2155 +/- ##
==========================================
- Coverage 91.79% 91.49% -0.30%
==========================================
Files 242 197 -45
Lines 17456 10845 -6611
Branches 2534 1356 -1178
==========================================
- Hits 16024 9923 -6101
+ Misses 1063 666 -397
+ Partials 369 256 -113
Continue to review full report at Codecov.
|
ryanjulian
reviewed
Oct 28, 2020
Member
ryanjulian
left a comment
There was a problem hiding this comment.
Do the tests pass under these configurations? Maybe at least run a pylint on both configs (it should detect importerrors)
ryanjulian
approved these changes
Oct 28, 2020
This was
linked to
issues
Oct 29, 2020
5bd4d70 to
8200b0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.