[FIX] If loadOptions changes, items are not reloaded#723
Open
extremegf wants to merge 3 commits intorob-balfre:masterfrom
Open
[FIX] If loadOptions changes, items are not reloaded#723extremegf wants to merge 3 commits intorob-balfre:masterfrom
extremegf wants to merge 3 commits intorob-balfre:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit e9f3a8f.
Author
|
I've removed the problem reproduction file. Vercel still has a problem which seems unrelated to my change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below animation shows the issue:
If loadOptions change, there is no other way to refresh items then either reload component of change filter and change it back.
To repro without fix:
Merging in the tests/reproductions/itemsNotRefreshed/+page.svelte is not necessary but might be useful.
I don't think this will have any impact on most svelte-select consumers, as this influences cases where loadOptions are passed as a prop. And in this use-cases it is more likely than not that you want the item refresh to happen.