Skip to content

"bad cookie" log levels warnings are inconsistent#819

Merged
Frky merged 1 commit intorobertdavidgraham:masterfrom
gpotter2:patch-1
Apr 17, 2026
Merged

"bad cookie" log levels warnings are inconsistent#819
Frky merged 1 commit intorobertdavidgraham:masterfrom
gpotter2:patch-1

Conversation

@gpotter2
Copy link
Copy Markdown
Contributor

@gpotter2 gpotter2 commented Mar 7, 2025

The other "bad cookie" warning is level 2:

LOG(2, "%s - bad cookie: ackno=0x%08x expected=0x%08x\n",

this other one occurs in --banners, it makes sense for them to be consistent

@gpotter2 gpotter2 closed this Mar 7, 2025
@gpotter2 gpotter2 reopened this Mar 7, 2025
@gpotter2
Copy link
Copy Markdown
Contributor Author

gpotter2 commented Mar 7, 2025

Hi @p-l- @Frky , this is ready for review !

Copy link
Copy Markdown
Collaborator

@p-l- p-l- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@Frky Frky merged commit b228476 into robertdavidgraham:master Apr 17, 2026
1 of 2 checks passed
@Frky
Copy link
Copy Markdown
Collaborator

Frky commented Apr 17, 2026

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants