Skip to content

Speed up function _negotiate_grid_size by 338% #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Speed up function _negotiate_grid_size by 338% #1670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36cab66
Optimize _negotiate_grid_size
codeflash-ai[bot] Oct 22, 2025
f5feccf
Merge branch 'main' into codeflash/optimize-_negotiate_grid_size-mh2m…
aseembits93 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions inference/core/utils/drawing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,18 @@ def _establish_grid_size(


def _negotiate_grid_size(images: List[np.ndarray]) -> Tuple[int, int]:
if len(images) <= MAX_COLUMNS_FOR_SINGLE_ROW_GRID:
return 1, len(images)
nearest_sqrt = math.ceil(np.sqrt(len(images)))
images_len = len(images)
if images_len <= MAX_COLUMNS_FOR_SINGLE_ROW_GRID:
return 1, images_len
# Use math.isqrt for efficient integer sqrt calculation
sqrt_len = math.isqrt(images_len)
if sqrt_len * sqrt_len == images_len:
nearest_sqrt = sqrt_len
else:
nearest_sqrt = sqrt_len + 1
proposed_columns = nearest_sqrt
proposed_rows = nearest_sqrt
while proposed_columns * (proposed_rows - 1) >= len(images):
proposed_rows -= 1
# Directly compute proposed_rows without a loop
proposed_rows = (images_len + proposed_columns - 1) // proposed_columns
return proposed_rows, proposed_columns


Expand Down