-
Notifications
You must be signed in to change notification settings - Fork 226
WebRTC python sdk - realtime updating channel outputs #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
digaobarbosa
wants to merge
23
commits into
webrtc-python-sdk-webcam
Choose a base branch
from
webrtc-python-sdk-update-channels
base: webrtc-python-sdk-webcam
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WebRTC python sdk - realtime updating channel outputs #1710
digaobarbosa
wants to merge
23
commits into
webrtc-python-sdk-webcam
from
webrtc-python-sdk-update-channels
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erence into lean/webrtc-data-decoupling
…o webrtc-python-sdk-update-channels
hansent
reviewed
Nov 12, 2025
| logger.info(f"Starting WebRTC worker with output_mode: {args.output_mode}") | ||
| if args.output_mode == "data_only": | ||
| logger.info( | ||
| "DATA_ONLY mode: Server will send JSON data via data channel only (no video track)" |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe dont want these changes in this PR
grzegorz-roboflow
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding sdk functionality to udpate outputs.
And adding the optional parameter to start the stream as data-only, depends on @lrosemberg branch #1700
It is also built on top of the initial webrtc sdk version: #1701
Which should be merged before this one too.
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
locally
Any specific deployment considerations
None
Docs
Not updated yet. But it will be done in a future PR