PR to make the repository compiled on Humble #44
Conversation
Fix compilation build for missing required dependency
|
@nim65s @saikishor could you have a final look to this PR for merging ? Thx in advance. |
|
@olivier-stasse I might have some changes locally. I can recheck and post here in a week. Next week I'll be at ERF |
| [submodule "cmake"] | ||
| path = cmake | ||
| url = git://github.com/jrl-umi3218/jrl-cmakemodules.git | ||
| url = https://github.com/jrl-umi3218/jrl-cmakemodules |
There was a problem hiding this comment.
Thanks @saikishor for the feedback. For some reason, the git link on my side is timing out where as the https link allows a fast submodule pull. For this reason the following command:
git clone --recurse-submodules http://github.com/roboptim/roboptim-core-plugin-ipopt.git
is not working due to a long timeout.
The travis submodule for me is also a problem. I had to individually init and update the cmake module.
- If you confirm that you have the same problem then I could remove also travis which is deprecated.
- If you do not have the problem, then I wonder what is the problem on my side.
There was a problem hiding this comment.
Yes, we need this change, ref https://github.blog/security/application-security/improving-git-protocol-security-github/#no-more-unauthenticated-git
3 participants
This PR implements the following modification to make the repository compiled under Humble: