Have Evd use einstance everywhere#21097
Merged
coqbot-app[bot] merged 2 commits intorocq-prover:masterfrom Oct 3, 2025
Merged
Conversation
coqbot-app
bot
added
the
needs: full CI
Contributor
No need to normalize for that, use the unsafe cast |
Contributor
|
or call retyping when getting a econstr is convenient |
Member
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
ppedrot
reviewed
Sep 22, 2025
| val is_flexible_level : evar_map -> Univ.Level.t -> bool | ||
|
|
||
| val normalize_universe_instance : evar_map -> UVars.Instance.t -> UVars.Instance.t | ||
| val normalize_universe_instance : evar_map -> einstance -> einstance |
Member
There was a problem hiding this comment.
This should be removed eventually.
ppedrot
approved these changes
Sep 22, 2025
ppedrot
added
the
needs: overlay
yannl35133
added a commit
to Yann-Leray/Coq-Equations
that referenced
this pull request
Oct 1, 2025
yannl35133
added a commit
to Yann-Leray/paramcoq
that referenced
this pull request
Oct 1, 2025
yannl35133
added a commit
to Yann-Leray/reduction-effects
that referenced
this pull request
Oct 1, 2025
yannl35133
added a commit
to Yann-Leray/coq-elpi
that referenced
this pull request
Oct 1, 2025
coqbot-app
bot
added
the
needs: full CI
Member
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
yannl35133
added a commit
to Yann-Leray/coq-elpi
that referenced
this pull request
Oct 1, 2025
ppedrot
removed
the
needs: overlay
Member
|
@coqbot merge now |
Contributor
|
@ppedrot: Please take care of the following overlays:
|
ppedrot
pushed a commit
to rocq-community/reduction-effects
that referenced
this pull request
Oct 3, 2025
ppedrot
added a commit
to rocq-community/paramcoq
that referenced
this pull request
Oct 3, 2025
Adapt to rocq-prover/rocq#21097 (Use einstance everywhere)
ppedrot
added a commit
to mattam82/Coq-Equations
that referenced
this pull request
Oct 3, 2025
Adapt to rocq-prover/rocq#21097 (Use einstance everywhere))
ppedrot
added a commit
to LPCIC/coq-elpi
that referenced
this pull request
Oct 3, 2025
Adapt to rocq-prover/rocq#21097 (Use einstance everywhere)
yannl35133
added a commit
to Yann-Leray/coq-tactician
that referenced
this pull request
Oct 3, 2025
LasseBlaauwbroek
added a commit
to coq-tactician/coq-tactician
that referenced
this pull request
Oct 7, 2025
Adapt to rocq-prover/rocq#21097 (use einstance everywhere)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SkySkimmer My biggest unknown is how to deal with Typeops.type_of_constant_in which doesn't seem to have an equivalent for econstr, so I cast everything back to constr every time.
Overlays: