Feature/9 admin vendor portal #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature/9-admin-vendor-portal
Author
|
@rohitnandi12 Please review PR , i'm will double check this tomorrow / day after again |
rohitnandi12
changed the base branch from
feature/9-admin-vendor-portal
to
dev
rohitnandi12
changed the base branch from
dev
to
feature/9-admin-vendor-portal
rohitnandi12
requested changes
Dec 9, 2024
| import org.springframework.data.web.SortDefault; | ||
| import org.springframework.http.HttpStatus; | ||
| import org.springframework.http.ResponseEntity; | ||
| import org.springframework.web.bind.annotation.*; |
...rc/main/java/org/lbcc/bms/bms_monolith/admin/controller/AdminVendorOnboardingController.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/lbcc/bms/bms_monolith/admin/controller/AdminVendorOnboardingController.java
Outdated
Show resolved
Hide resolved
| @PageableDefault(page = 0, size = 10) | ||
| @SortDefault(sort = "name", direction = Sort.Direction.ASC) Pageable pageable) { | ||
|
|
||
| Page<Vendor> vendorsPage = adminService.searchVendors(searchRequest, pageable); |
Author
There was a problem hiding this comment.
adminService.searchVendors(searchRequest, pageable); method is already returning a Page right,
not understanding this comment
...ms-monolith/src/main/java/org/lbcc/bms/bms_monolith/admin/controller/SeatTypeController.java
Outdated
Show resolved
Hide resolved
...nd/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/admin/service/AdminService.java
Outdated
Show resolved
Hide resolved
...bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/admin/service/VendorSpecifications.java
Show resolved
Hide resolved
...ckend/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/common/config/JpaConfig.java
Show resolved
Hide resolved
|
|
||
| @ManyToOne //fetch = FetchType.LAZY | ||
| @JoinColumn(name = "seat_id", nullable = false) | ||
| private Seat seat; |
Owner
There was a problem hiding this comment.
This may lead to a Hibernate N+1 query problem.
Author
There was a problem hiding this comment.
have tried to resolve this with eager fetching , please confirm if this solves the issue
|
|
||
| @ManyToOne(cascade = CascadeType.ALL, fetch = FetchType.LAZY) | ||
| @JoinColumn(name = "address_id") | ||
| private Address address; |
Owner
There was a problem hiding this comment.
How is this ManyToOne? One Venue can have only one Address right?
Author
There was a problem hiding this comment.
the logic is 1 address can belong to multiple venues (assuming they are nearby) , 1 venue will have 1 address.
we can discuss and clarify things
|
|
||
| @GetMapping | ||
| public ResponseEntity<?> getAllVendors( | ||
| @ModelAttribute VendorSearchRequest searchRequest, |
PR comments resolution
…nto feature/9-admin-vendor-portal # Conflicts: # book-my-show/backend/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/admin/controller/AdminVendorOnboardingController.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.