Skip to content

Update calculator.py #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update calculator.py #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/calculator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,8 @@ def divide(x, y):
if y == 0:
return 'Cannot divide by 0'
return x * 1.0 / y

def divide(x, y):
if y == 0:
return 'Cannot divide by 0'
return x * 1.0 / y * 5
Comment on lines +18 to +21
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical Issue: Duplicate method definition

This code defines a second divide method with the same name as the existing one (lines 13-16). In Python, the second definition will completely overwrite the first one, making the original divide method inaccessible.

Additionally, based on the indentation shown (4 spaces), this appears to be nested inside the first divide method, which would create a local function that's never called or accessible from outside.

Impact:

  • If this overwrites the original method, it breaks the expected behavior of division by multiplying results by 5
  • Existing tests will fail (e.g., test_divide expects Calculator.divide(1.0, 2.0) == 0.5, but this would return 2.5)
  • This is a breaking change for any consumers of the Calculator class

Recommendation:

  • If you need a method that divides and multiplies by 5, create a new method with a descriptive name like divideAndMultiplyBy5
  • If this was meant to replace the original divide method, please provide justification for changing the mathematical behavior
  • Remove this duplicate definition and either keep the original or create a properly named new method
Suggested change
def divide(x, y):
if y == 0:
return 'Cannot divide by 0'
return x * 1.0 / y * 5
# If you need division multiplied by 5, create a new method:
def divideAndMultiplyBy5(x, y):
if y == 0:
return 'Cannot divide by 0'
return x * 1.0 / y * 5

Did we get this right? 👍 / 👎 to inform future reviews.