Skip to content

Conversation

@krakow10
Copy link
Contributor

@krakow10 krakow10 commented Jun 2, 2025

Not the most important part of rbx-dom, but hey it's -38 loc. The only functional difference should be that the faces are printed in all caps. Updating bitflags shouldn't be a breaking change because it's a private type in a private field.

Here's a small test that I ran to prove it works:

#[test]
fn single() {
    let f = Faces {
        flags: FaceFlags::BACK,
    };
    let text = format!("{f:?}");
    assert_eq!(text, "Faces(BACK)");
}
#[test]
fn double() {
    let f = Faces {
        flags: FaceFlags::BOTTOM | FaceFlags::RIGHT,
    };
    let text = format!("{f:?}");
    assert_eq!(text, "Faces(RIGHT, BOTTOM)");
}

@krakow10 krakow10 changed the title Convert Lister To Use Iterators Replace Lister With Function Using Iterators Jun 2, 2025
@Dekkonot
Copy link
Member

Dekkonot commented Jun 9, 2025

I'm not actually convinced this provides any value. Technically it improves Lister... but as you said, that's used for what, the Debug implementation for Faces and Axes?

It doesn't provide enough to warrant changing the debug output for Faces IMO, but I'll invite @kennethloeffler to share his thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants