Skip to content

Ignore breakpoints from unsupported files #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TwitchBronBron wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Ignore breakpoints from unsupported files #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions src/debugSession/BrightScriptDebugSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,18 +81,17 @@ export class BrightScriptDebugSession extends BaseDebugSession {
this.sourceMapManager = new SourceMapManager();
this.locationManager = new LocationManager(this.sourceMapManager);
this.breakpointManager = new BreakpointManager(this.sourceMapManager, this.locationManager);
//send newly-verified breakpoints to vscode
this.breakpointManager.on('breakpoints-verified', (data) => this.onDeviceBreakpointsChanged('changed', data));
//send breakpoint state changes to vscode
this.breakpointManager.on('breakpoints-changed', (data: { breakpoints: AugmentedSourceBreakpoint[] }) => this.onBreakpointChanged(data));
this.projectManager = new ProjectManager({
breakpointManager: this.breakpointManager,
locationManager: this.locationManager
});
this.fileLoggingManager = new FileLoggingManager();
}

private onDeviceBreakpointsChanged(eventName: 'changed' | 'new', data: { breakpoints: AugmentedSourceBreakpoint[] }) {
this.logger.info('Sending verified device breakpoints to client', data);
//send all verified breakpoints to the client
private onBreakpointChanged(data: { breakpoints: AugmentedSourceBreakpoint[] }) {
this.logger.info('Sending breakpoint changes to client', data);
for (const breakpoint of data.breakpoints) {
const event: DebugProtocol.Breakpoint = {
line: breakpoint.line,
Expand All @@ -105,7 +104,11 @@ export class BrightScriptDebugSession extends BaseDebugSession {
path: breakpoint.srcPath
}
};
this.sendEvent(new BreakpointEvent(eventName, event));
// Determine the DAP event reason from the breakpoint state:
// - 'failed' breakpoints (e.g. unsupported file types) should be removed from the client
// - all other state changes are updates to existing breakpoints
const reason = breakpoint.reason === 'failed' ? 'removed' : 'changed';
this.sendEvent(new BreakpointEvent(reason, event));
}
}

Expand Down Expand Up @@ -415,7 +418,6 @@ export class BrightScriptDebugSession extends BaseDebugSession {
return this.shutdown(`Could not resolve ip address for host '${this.launchConfiguration.host}'`);
}


// fetches the device info and parses the xml data to JSON object
try {
this.deviceInfo = await rokuDeploy.getDeviceInfo({ host: this.launchConfiguration.host, remotePort: this.launchConfiguration.remotePort, enhance: true, timeout: 4_000 });
Expand All @@ -428,11 +430,9 @@ export class BrightScriptDebugSession extends BaseDebugSession {
}
return this.shutdown(`Unable to connect to roku at '${this.launchConfiguration.host}'. Verify the IP address is correct and that the device is powered on and connected to same network as this computer.`);
}

if (this.deviceInfo && !this.deviceInfo.developerEnabled) {
return this.shutdown(`Developer mode is not enabled for host '${this.launchConfiguration.host}'.`);
}

await this.initializeProfiling();
//initialize all file logging (rokuDevice, debugger, etc)
this.fileLoggingManager.activate(this.launchConfiguration?.fileLogging, this.cwd);
Expand Down Expand Up @@ -547,7 +547,6 @@ export class BrightScriptDebugSession extends BaseDebugSession {
await this.tryProfilingConnectOnStart();

await this.publish();


//hack for certain roku devices that lock up when this event is emitted (no idea why!).
if (this.launchConfiguration.emitChannelPublishedEvent) {
Expand Down
Loading