Fix path.resolve() discarding staging prefix for leading-slash dest#248
Closed
cewert wants to merge 1 commit intorokucommunity:masterfrom
Closed
Fix path.resolve() discarding staging prefix for leading-slash dest#248cewert wants to merge 1 commit intorokucommunity:masterfrom
cewert wants to merge 1 commit intorokucommunity:masterfrom
Conversation
Replace path.resolve() with defensive logic in copyToStaging() and zipFolder() so that dest values starting with "/" no longer silently discard the base staging path. This regressed in 3.16.4 (PR rokucommunity#245).
Member
|
Hey, thanks for this. I think the bug in the VS Code extension was caused by something slightly different, so I’m not sure this is the implementation I want to add. The absolute change made in #245 supports writing things outside of outDir and rootDir, which was necessary for when vscode users want to set I just opened #249 and rokucommunity/roku-debug#329 to resolve the vscode issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #245 replaced string interpolation with
path.resolve()incopyToStaging()andzipFolder(). Whendeststarts with/,path.resolve()silently discards the base staging path, causingEACCES: permission denied, mkdir '/source'.Changes
path.resolve()incopyToStaging()with defensive logic that checks ifdestis already an absolute path understagingPath(use as-is) or otherwise strips leading slashes and usespath.join()zipFolder()for zip entry path construction