Skip to content

fix: correct DeviceInfoRaw serial-number property name#251

Merged
chrisdp merged 2 commits intomasterfrom
copilot/update-deviceinfo-serial-number
Apr 15, 2026
Merged

fix: correct DeviceInfoRaw serial-number property name#251
chrisdp merged 2 commits intomasterfrom
copilot/update-deviceinfo-serial-number

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 15, 2026

DeviceInfoRaw had 'serialNumber' as a typed property, but the Roku ECP response uses the kebab-case XML tag <serial-number>. This caused a type mismatch — raw lookups via deviceInfo['serial-number'] were untyped while deviceInfo['serialNumber'] (which never exists in the response) was typed.

Change

  • src/DeviceInfo.ts: Rename 'serialNumber'?: string'serial-number'?: string in DeviceInfoRaw, consistent with every other property in that interface.
 export interface DeviceInfoRaw {
     'udn'?: string;
-    'serialNumber'?: string;
+    'serial-number'?: string;
     'deviceId'?: string;

Note: DeviceInfo (the enhanced/camelCase variant returned when enhance: true) correctly retains serialNumber — no change needed there.

Original prompt

Problem

The DeviceInfoRaw interface in DeviceInfo.ts has an incorrect property name. It currently uses serialNumber but should be serial-number to match the actual device info format.

Task

Update the DeviceInfoRaw interface in DeviceInfo.ts:

  • Change the property name from serialNumber to serial-number
  • Ensure any references to this property are updated accordingly
  • Verify the fix aligns with the actual Roku device info response format

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Open a pull request on roku-deploy to fix DeviceInfo.ts to fix the DeviceInfoRaw interface. it has serialNumber but it should be serial-number.

Assistant: I'll help you create a pull request to fix the DeviceInfoRaw interface in DeviceInfo.ts. Let me create a PR to change serialNumber to serial-number.

Assistant: I'm waiting for your confirmation to proceed with creating the pull request that will fix the DeviceInfoRaw interface property name from serialNumber to serial-number in DeviceInfo.ts.

This pull request was created from Copilot chat.

Agent-Logs-Url: https://github.com/rokucommunity/roku-deploy/sessions/e8999bd1-9ebe-4cd9-8a60-13e522db4ec0

Co-authored-by: TwitchBronBron <2544493+TwitchBronBron@users.noreply.github.com>
Copilot AI changed the title [WIP] Update DeviceInfoRaw interface to correct serial-number property fix: correct DeviceInfoRaw serial-number property name Apr 15, 2026
Copilot AI requested a review from TwitchBronBron April 15, 2026 18:56
@chrisdp chrisdp marked this pull request as ready for review April 15, 2026 21:36
@chrisdp chrisdp enabled auto-merge April 15, 2026 21:36
@chrisdp chrisdp merged commit f424fc9 into master Apr 15, 2026
7 checks passed
@chrisdp chrisdp deleted the copilot/update-deviceinfo-serial-number branch April 15, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants