fix: correct DeviceInfoRaw serial-number property name#251
Merged
Conversation
Agent-Logs-Url: https://github.com/rokucommunity/roku-deploy/sessions/e8999bd1-9ebe-4cd9-8a60-13e522db4ec0 Co-authored-by: TwitchBronBron <2544493+TwitchBronBron@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update DeviceInfoRaw interface to correct serial-number property
fix: correct DeviceInfoRaw serial-number property name
Apr 15, 2026
chrisdp
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeviceInfoRawhad'serialNumber'as a typed property, but the Roku ECP response uses the kebab-case XML tag<serial-number>. This caused a type mismatch — raw lookups viadeviceInfo['serial-number']were untyped whiledeviceInfo['serialNumber'](which never exists in the response) was typed.Change
src/DeviceInfo.ts: Rename'serialNumber'?: string→'serial-number'?: stringinDeviceInfoRaw, consistent with every other property in that interface.export interface DeviceInfoRaw { 'udn'?: string; - 'serialNumber'?: string; + 'serial-number'?: string; 'deviceId'?: string;Note:
DeviceInfo(the enhanced/camelCase variant returned whenenhance: true) correctly retainsserialNumber— no change needed there.Original prompt
This pull request was created from Copilot chat.