Skip to content

Skip health checks when opening device picker#757

Merged
TwitchBronBron merged 8 commits intomasterfrom
limit-health-checks-on-device-picker
Apr 15, 2026
Merged

Skip health checks when opening device picker#757
TwitchBronBron merged 8 commits intomasterfrom
limit-health-checks-on-device-picker

Conversation

@Christian-Holbrook
Copy link
Copy Markdown
Collaborator

@Christian-Holbrook Christian-Holbrook commented Apr 14, 2026

Summary

Adds

  • DeviceManager.scan() method for discovery without health checks
  • Device picker now uses scan() instead of refresh() on open
  • Health checks still occur on refresh button click or device selection
  • Remove stale devices via a scan. Set the device online state when it is fresh enough in the cache
  • Fix bug with clear button not clearing the cache
  • Fix bug with discovered devices not being remembered in the "lastSeenDevices" list on reload

Test plan

  • Unit tests for scan() method
  • Integration test verifying picker calls scan() not refresh()

…hown. Add a test to help preserve this functionality
@TwitchBronBron TwitchBronBron enabled auto-merge (squash) April 15, 2026 19:57
@TwitchBronBron TwitchBronBron merged commit 12ef632 into master Apr 15, 2026
6 checks passed
@TwitchBronBron TwitchBronBron deleted the limit-health-checks-on-device-picker branch April 15, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants