Skip to content

chore: Simplify create-vsix inputs and improve branch resolution - #867

Merged
TwitchBronBron merged 1 commit into
masterfrom
create-vsix-single-pr-input
Jul 31, 2026
Merged

chore: Simplify create-vsix inputs and improve branch resolution#867
TwitchBronBron merged 1 commit into
masterfrom
create-vsix-single-pr-input

Conversation

@TwitchBronBron

Copy link
Copy Markdown
Member

What

  • The workflow_dispatch now takes a single pr input: a PR number (for this repo), a full PR URL (for any repo), or a branch name — replacing the separate branch/pr/repo inputs.
  • scripts/create-vsix.ts now resolves each project's build source with this priority:
    1. rokucommunity branch attached to an open PR
    2. the originating fork owner's same-named branch attached to an open PR (clones the fork)
    3. rokucommunity branch without a PR
    4. master
  • The PR comment now includes a Built from: section listing exactly which source each of the 5 projects was built from.

Why

  • Fork PRs previously built silently from master (the fork's branch never exists on the rokucommunity clone), producing a vsix with none of the PR's changes. Now the fork branch is used — but only when it belongs to the same owner as the originating PR and is attached to an open PR, so an unrelated fork's patch-1 can never leak into a build.
  • Upstream repos no longer need to pass branch/repo — just the PR URL.

Rollout

⚠️ Must merge together with the matching PRs on the dispatcher repos (brighterscript, roku-debug, roku-deploy, brighterscript-formatter, logger, roku-test-automation) — workflow_dispatch rejects unknown inputs, so the old branch/repo payloads fail once this merges.

🤖 Generated with Claude Code

The workflow_dispatch now takes a single `pr` input (PR number for this
repo, full PR URL for any repo, or a branch name) instead of separate
branch/pr/repo inputs.

The build script now resolves each project's source with this priority:
1. rokucommunity branch attached to an open PR
2. the originating fork owner's same-named branch attached to an open PR
3. rokucommunity branch without a PR
4. master

This means fork PRs now get built from the fork instead of silently
falling back to master. The PR comment also lists exactly which source
each project was built from.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant