Security enhancements - #869
Merged
Merged
Conversation
Resolves brace-expansion, js-yaml, @babel/core, fast-uri, body-parser, shell-quote, ip-address, and linkify-it, all pulled in exclusively through devDependencies or as unreachable code paths in prod dependencies (postman-request's SOCKS proxy support, @vscode/vsce's markdown renderer). Also fixes the qs DoS in postman-request directly, and fixes postcss in the webviews subproject. uuid stays at ^9.0.1 and remains allowlisted in audit-ci.jsonc: uuid@11's bundled .d.ts uses `export type *` syntax requiring TypeScript 5.0+, which breaks this project's build under its current typescript@^4.7.4. The vulnerable code path (v3/v5/v6 with a caller-provided buffer) is unreachable here regardless, since every consumer (our own code, postman-request, node-notifier, nyc) only calls v4(). ip/node-ssdp remains allowlisted as well: ip has no fixed release at all, and node-ssdp's latest version still depends on it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
TwitchBronBron
added
the
Security enhancements
TwitchBronBron
changed the title
@vscode/vsce@3.9.2 (latest) bundles markdown-it@14.2.0, which pins linkify-it@^5.0.1 and calls `new LinkifyIt(...)`. Forcing linkify-it@^6.1.0 changed that export's shape and broke `npm run create-package` with "LinkifyIt is not a constructor" (CI failure on all three platforms). No override is needed at all: a fresh install resolves markdown-it's ^5.0.1 range to linkify-it@5.0.2, which is already past the vulnerable <=5.0.1 range from GHSA-v245-v573-v5vm. Verified `create-package` succeeds and the full audit still passes with 0 new findings. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code