Implemented drop down list for integer parameters with additional constraints. (#150)#151
Open
himaj47 wants to merge 1 commit intoros-visualization:rollingfrom
Open
Implemented drop down list for integer parameters with additional constraints. (#150)#151himaj47 wants to merge 1 commit intoros-visualization:rollingfrom
himaj47 wants to merge 1 commit intoros-visualization:rollingfrom
Conversation
| Parameter.Type.BYTE_ARRAY: ArrayEditor, | ||
| Parameter.Type.INTEGER_ARRAY: ArrayEditor, | ||
| Parameter.Type.DOUBLE_ARRAY: ArrayEditor, | ||
| Parameter.Type.STRING_ARRAY: ArrayEditor, |
There was a problem hiding this comment.
why delete ARRAY type here?
i have tried directly adding DROP_DOWN_LIST, it works.
ahcorde
requested changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #150 is resolved.
Changes Made
Added
DropDownListEditorclass in params_editor script which parses theadditional_constraintsas key-value pairs in CSV format and fills the drop-down list, while passing the corresponding integer value (keys) in parameter updates.Introduced key-value pair {
"DROP_DOWN_LIST":DropDownListEditor} inEDITOR_TYPESUpdated
add_editor_widgetsfunction to check if an integer parameter's descriptor has an additional_constraints and assignDropDownListEditorinstead of the default integer editor if it does.added a new Qt Widget
editor_drop_down_list.uiwhich uses QComboBox to implement drop down list feature.This is How it looks