Skip to content

Conversation

@fujitatomoya
Copy link
Contributor

@fujitatomoya fujitatomoya commented Dec 13, 2025

Description

Is this user-facing behavior change?

Yes, but barely noticeable.

Did you use Generative AI?

No

Additional Information

@fujitatomoya fujitatomoya self-assigned this Dec 13, 2025
@fujitatomoya
Copy link
Contributor Author

Pulls: #2262
Gist: https://gist.githubusercontent.com/fujitatomoya/2720add1a832706ccb08d8d797d53b5d/raw/de935fa174fd2fa7eee11dbe1100718f9a189864/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_storage
TEST args: --packages-above rosbag2_storage
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17779

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov changed the title throw YAML::Exception during conversion if the data type mismatches. Throw YAML::Exception during conversion if the data type mismatches. Dec 22, 2025
@fujitatomoya
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fujitatomoya fujitatomoya merged commit 2f89eec into rolling Jan 8, 2026
11 of 12 checks passed
@fujitatomoya
Copy link
Contributor Author

@Mergifyio backport jazzy kilted

@mergify
Copy link

mergify bot commented Jan 8, 2026

backport jazzy kilted

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jan 8, 2026
…2262)

* throw YAML::Exception during conversion if the data type mismatches.

Signed-off-by: Tomoya.Fujita <[email protected]>

* fix build failure for dependent packages.

Signed-off-by: Tomoya Fujita <[email protected]>

* explicitly handle the decoder exception.

Signed-off-by: Tomoya Fujita <[email protected]>

---------

Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 2f89eec)
mergify bot pushed a commit that referenced this pull request Jan 8, 2026
…2262)

* throw YAML::Exception during conversion if the data type mismatches.

Signed-off-by: Tomoya.Fujita <[email protected]>

* fix build failure for dependent packages.

Signed-off-by: Tomoya Fujita <[email protected]>

* explicitly handle the decoder exception.

Signed-off-by: Tomoya Fujita <[email protected]>

---------

Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 2f89eec)
MichaelOrlov pushed a commit that referenced this pull request Jan 8, 2026
…2262) (#2304)

* throw YAML::Exception during conversion if the data type mismatches.



* fix build failure for dependent packages.



* explicitly handle the decoder exception.



---------



(cherry picked from commit 2f89eec)

Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The YAML parser of StorageOptions does not throw an exception for invalid input

3 participants