-
Notifications
You must be signed in to change notification settings - Fork 292
[kilted] Use QoS override settings for inner Rosbag2 publishing topics (backport #2286) #2302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Use QoS override settings for inner Rosbag2 topics - Use QoS override settings for the RecorderEventNotifier - Use QoS override settings for "events/read_split" topic - Rename private RecorderEventNotifierImpl::node to the node_ Signed-off-by: Michael Orlov <[email protected]> * Use fully qualified name when searching for qos overrides - Use fully qualified name when searching for qos overrides for inner Rosbag2 topics Signed-off-by: Michael Orlov <[email protected]> * Address review comments. Add missing includes Signed-off-by: Michael Orlov <[email protected]> * Remove duplicating declaration of "Rosbag2QoS EventQoS()" after rebase Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit fdbcc70) # Conflicts: # rosbag2_transport/include/rosbag2_transport/recorder_event_notifier.hpp # rosbag2_transport/src/rosbag2_transport/recorder_event_notifier.cpp # rosbag2_transport/src/rosbag2_transport/recorder_event_notifier_impl.hpp # rosbag2_transport/test/rosbag2_transport/test_recorder_event_notifier.cpp
|
Cherry-pick of fdbcc70 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
…events Signed-off-by: Michael Orlov <[email protected]>
|
Pulls: #2302 |
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been createdDetails
|
…s (backport #2286) (#2302) Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit 1d7a970)
Description
This PR will add the ability to override the Rosbag2's inner publishing topics, such as
write{read}_split_eventandmessages_lost_eventwithbag record --qos-profile-overrides-pathCLI option.Is this user-facing behavior change?
Yes. The user will have the ability to override the Rosbag2's inner publishing topics, such as
write{read}_split_eventandmessages_lost_eventwithbag record --qos-profile-overrides-pathCLI option.Did you use Generative AI?
Yes. I am using GitHub Copilot, GPT-5 in my workflow. Mostly to help with test creation and Doxygen comments.
Additional Information
This PR has an API breaking changes in the
RecorderEventNotifierclass. However, if we will merge it before the next Rosbag2 release on Jazzy and Kilted. We will not break API because theRecorderEventNotifierclass itself was introduced recently after the latest current release.cc: @ahcorde
This is an automatic backport of pull request #2286 done by Mergify.