Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Jan 8, 2026

Description

This PR will add the ability to override the Rosbag2's inner publishing topics, such as write{read}_split_event and messages_lost_event with bag record --qos-profile-overrides-path CLI option.

Is this user-facing behavior change?

Yes. The user will have the ability to override the Rosbag2's inner publishing topics, such as write{read}_split_event and messages_lost_event with bag record --qos-profile-overrides-path CLI option.

Did you use Generative AI?

Yes. I am using GitHub Copilot, GPT-5 in my workflow. Mostly to help with test creation and Doxygen comments.

Additional Information

This PR has an API breaking changes in the RecorderEventNotifier class. However, if we will merge it before the next Rosbag2 release on Jazzy and Kilted. We will not break API because the RecorderEventNotifier class itself was introduced recently after the latest current release.
cc: @ahcorde


This is an automatic backport of pull request #2286 done by Mergify.

* Use QoS override settings for inner Rosbag2 topics

- Use QoS override settings for the RecorderEventNotifier
- Use QoS override settings for "events/read_split" topic
- Rename private RecorderEventNotifierImpl::node to the node_

Signed-off-by: Michael Orlov <[email protected]>

* Use fully qualified name when searching for qos overrides

- Use fully qualified name when searching for qos overrides for inner
 Rosbag2 topics

Signed-off-by: Michael Orlov <[email protected]>

* Address review comments. Add missing includes

Signed-off-by: Michael Orlov <[email protected]>

* Remove duplicating declaration of "Rosbag2QoS EventQoS()" after rebase

Signed-off-by: Michael Orlov <[email protected]>

---------

Signed-off-by: Michael Orlov <[email protected]>
(cherry picked from commit fdbcc70)

# Conflicts:
#	rosbag2_transport/include/rosbag2_transport/recorder_event_notifier.hpp
#	rosbag2_transport/src/rosbag2_transport/recorder_event_notifier.cpp
#	rosbag2_transport/src/rosbag2_transport/recorder_event_notifier_impl.hpp
#	rosbag2_transport/test/rosbag2_transport/test_recorder_event_notifier.cpp
@mergify
Copy link
Author

mergify bot commented Jan 8, 2026

Cherry-pick of fdbcc70 has failed:

On branch mergify/bp/kilted/pr-2286
Your branch is up to date with 'origin/kilted'.

You are currently cherry-picking commit fdbcc70.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rosbag2_transport/src/rosbag2_transport/player.cpp
	modified:   rosbag2_transport/src/rosbag2_transport/recorder.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rosbag2_transport/include/rosbag2_transport/recorder_event_notifier.hpp
	both modified:   rosbag2_transport/src/rosbag2_transport/recorder_event_notifier.cpp
	both modified:   rosbag2_transport/src/rosbag2_transport/recorder_event_notifier_impl.hpp
	both modified:   rosbag2_transport/test/rosbag2_transport/test_recorder_event_notifier.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Jan 8, 2026
@MichaelOrlov MichaelOrlov changed the title Use QoS override settings for inner Rosbag2 publishing topics (backport #2286) [kilted] Use QoS override settings for inner Rosbag2 publishing topics (backport #2286) Jan 8, 2026
@MichaelOrlov
Copy link
Contributor

Pulls: #2302
Gist: https://gist.githubusercontent.com/MichaelOrlov/bfd33475f3233993e30bbf0244cc36d9/raw/c031ec09357a9e88b024c6174b7120a6c4a27eb3/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_storage rosbag2_transport rosbag2_tests
TEST args: --packages-above rosbag2_storage rosbag2_transport rosbag2_tests
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17891

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 1d7a970 into kilted Jan 9, 2026
12 checks passed
@ahcorde ahcorde deleted the mergify/bp/kilted/pr-2286 branch January 9, 2026 11:54
@MichaelOrlov
Copy link
Contributor

https://github.com/Mergifyio backport jazzy

@mergify
Copy link
Author

mergify bot commented Jan 9, 2026

backport jazzy

✅ Backports have been created

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants