Fix FressianWriteHandler serialization bug #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Why is the change being made? Clojure Fressian has a bug when serializing maps, see here for details: clojure/data.fressian#14 This means users of DynamicObject have to serialize dynamic objects at least twice (serialize -> deserialize -> serialize) to get a consistent serialization. ## What has changed to address the problem? Changed FressianSerialization to create a PersistentHashMap if we are writing a map of size 8. This ensures that every serialization of a dynamic object returns the same value. ## How was this change tested? Test-driven development. Reproduced the bug via a unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is the change being made?
Clojure Fressian has a bug when serializing maps, see here for details:
clojure/data.fressian#14
This means users of DynamicObject have to serialize dynamic objects at least twice
(serialize -> deserialize -> serialize)
to get a consistent serialization.
What has changed to address the problem?
Changed FressianSerialization to create a PersistentHashMap if we are writing a map of size 8. This ensures that every serialization of a dynamic object returns the same value.
How was this change tested?
Test-driven development. Reproduced the bug via a unit test.
Things to consider
We may want to consider whether this introduces issues as the first serialization with this commit will be different compared to the first Fressian serialization without this commit.