Skip to content

feat(workbench): add annotations for session cm #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −0
Open

feat(workbench): add annotations for session cm #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f3548b
feat(workbench): add annotations option for session cm
koralowiec Jan 15, 2025
a34bc84
docs(workbench): update README
koralowiec Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/rstudio-workbench/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ Use of [Sealed secrets](https://github.com/bitnami-labs/sealed-secrets) disables
| affinity | object | `{}` | A map used verbatim as the pod's "affinity" definition |
| args | list | `[]` | args is the pod container's run arguments. |
| command | list | `[]` | command is the pod container's run command. By default, it uses the container's default. However, the chart expects a container using `supervisord` for startup |
| config.annotations.session | object | `{}` | annotations for ConfigMap created for sessions |
| config.defaultMode.jobJsonOverrides | int | 0644 | default mode for jobJsonOverrides config |
| config.defaultMode.pam | int | 0644 | default mode for pam scripts |
| config.defaultMode.prestart | int | 0755 | default mode for prestart config |
Expand Down
4 changes: 4 additions & 0 deletions charts/rstudio-workbench/templates/configmap-session.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
apiVersion: v1
kind: ConfigMap
metadata:
annotations:
{{- tpl ( toYaml .Values.config.annotations.session ) . | nindent 4 }}
name: {{ include "rstudio-workbench.fullname" . }}-session
namespace: {{ $.Release.Namespace }}
data:
Expand Down Expand Up @@ -44,6 +46,8 @@ stringData:
apiVersion: v1
kind: ConfigMap
metadata:
annotations:
{{- tpl ( toYaml .Values.config.annotations.session ) . | nindent 4 }}
name: {{ include "rstudio-workbench.fullname" . }}-session
namespace: {{ $targetNamespace }}
data:
Expand Down
4 changes: 4 additions & 0 deletions charts/rstudio-workbench/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,10 @@ config:
# @default -- 0644
pam: 0644

annotations:
# -- annotations for ConfigMap created for sessions
session: {}

# -- a map of session-scoped config files. Mounted to `/mnt/session-configmap/rstudio/` on both server and session, by default.
session:
repos.conf:
Expand Down