Skip to content

Chronicle agent server address resolution fixes #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Chronicle agent server address resolution fixes #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
81ca573
Skip rstudio-library call for Chronicle Agent server address if auto-…
ianpittwood Aug 6, 2025
114f230
Enhance server address template logic to check lookup returns values
ianpittwood Aug 6, 2025
af16709
Bump rstudio-library
ianpittwood Aug 6, 2025
6a4ca23
Bump rstudio-workbench and rstudio-connect
ianpittwood Aug 6, 2025
a2aa494
Update helm-docs and README.md
actions-user Aug 6, 2025
bc17041
Merge branch 'main' into chronicle-server-address-discovery-fixes
matt-urbina Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/rstudio-connect/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: rstudio-connect
description: Official Helm chart for Posit Connect
version: 0.8.9
version: 0.8.10
apiVersion: v2
appVersion: 2025.09.0
icon: https://rstudio.com/wp-content/uploads/2018/10/RStudio-Logo-Flat.png
Expand Down
5 changes: 5 additions & 0 deletions charts/rstudio-connect/NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 0.8.10

- Skip `rstudio-library` template call when `chronicleAgent.autoDiscovery=false`. Require `chronicleAgent.serverAddress`
to be set instead.

## 0.8.9

- Bump Connect version to 2025.09.0
Expand Down
6 changes: 3 additions & 3 deletions charts/rstudio-connect/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Posit Connect

![Version: 0.8.9](https://img.shields.io/badge/Version-0.8.9-informational?style=flat-square) ![AppVersion: 2025.09.0](https://img.shields.io/badge/AppVersion-2025.09.0-informational?style=flat-square)
![Version: 0.8.10](https://img.shields.io/badge/Version-0.8.10-informational?style=flat-square) ![AppVersion: 2025.09.0](https://img.shields.io/badge/AppVersion-2025.09.0-informational?style=flat-square)

#### _Official Helm chart for Posit Connect_

Expand Down Expand Up @@ -30,11 +30,11 @@ To ensure reproducibility in your environment and insulate yourself from future

## Installing the chart

To install the chart with the release name `my-release` at version 0.8.9:
To install the chart with the release name `my-release` at version 0.8.10:

```{.bash}
helm repo add rstudio https://helm.rstudio.com
helm upgrade --install my-release rstudio/rstudio-connect --version=0.8.9
helm upgrade --install my-release rstudio/rstudio-connect --version=0.8.10
```

To explore other chart versions, look at:
Expand Down
4 changes: 4 additions & 0 deletions charts/rstudio-connect/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,11 @@ spec:
{{- end }}
env:
- name: CHRONICLE_SERVER_ADDRESS
{{- if .Values.chronicleAgent.autoDiscovery }}
value: {{ include "rstudio-library.chronicle-agent.serverAddress" (dict "chronicleAgent" .Values.chronicleAgent "Release" .Release) | trim | quote }}
{{- else }}
value: {{ required "chronicleAgent.serverAddress must be specified if autoDiscovery is disabled." .Values.chronicleAgent.serverAddress | quote }}
{{- end }}
- name: CHRONICLE_CONNECT_APIKEY
{{- if .Values.chronicleAgent.connectApiKey.valueFrom }}
valueFrom:
Expand Down
4 changes: 2 additions & 2 deletions charts/rstudio-library/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: rstudio-library
description: Helm library helpers for use by official RStudio charts
type: library
version: 0.1.34
appVersion: 0.1.34
version: 0.1.35
appVersion: 0.1.35

icon: https://rstudio.com/wp-content/uploads/2018/10/RStudio-Logo-Flat.png
home: https://www.rstudio.com
Expand Down
5 changes: 5 additions & 0 deletions charts/rstudio-library/NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

# 0.1.35

- Fix `rstudio-library.chronicle-agent.serverAddress` failure when lookup returns none.
- Fail `rstudio-library.chronicle-agent.serverAddress` if no server address could be resolved.

## 0.1.34

- Add HTTP/HTTPS protocol prefix to `rstudio-library.chronicle-agent.serverAddress` function return.
Expand Down
2 changes: 1 addition & 1 deletion charts/rstudio-library/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# rstudio-library

![Version: 0.1.34](https://img.shields.io/badge/Version-0.1.34-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square) ![AppVersion: 0.1.34](https://img.shields.io/badge/AppVersion-0.1.34-informational?style=flat-square)
![Version: 0.1.35](https://img.shields.io/badge/Version-0.1.35-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square) ![AppVersion: 0.1.35](https://img.shields.io/badge/AppVersion-0.1.35-informational?style=flat-square)

#### _Helm library helpers for use by official RStudio charts_

Expand Down
4 changes: 3 additions & 1 deletion charts/rstudio-library/templates/_chronicle-agent.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,15 @@ Takes a dict:
{{- define "rstudio-library.chronicle-agent.serverAddress" }}
{{- if .chronicleAgent.serverAddress }}
{{- .chronicleAgent.serverAddress }}
{{- else }}
{{- else if lookup "v1" "Service" (default .Release.Namespace .chronicleAgent.serverNamespace) "" }}
{{- range $index, $service := (lookup "v1" "Service" (default .Release.Namespace .chronicleAgent.serverNamespace) "").items }}
{{- $name := get $service.metadata.labels "app.kubernetes.io/name" }}
{{- $component := get $service.metadata.labels "app.kubernetes.io/component" }}
{{- if and (eq $name "posit-chronicle") (eq $component "server") }}
{{- (index $service.spec.ports 0).name }}://{{ $service.metadata.name }}.{{ $service.metadata.namespace }}
{{- end }}
{{- end }}
{{- else }}
{{- fail "Unable to resolve a Chronicle server address for Chronicle agent. Ensure that a Chronicle server is deployed in the same namespace as this chart or the namespace is specfied with chronicleAgent.serverNamespace when using chronicleAgent.autoDiscovery=true. Alternatively, specify chronicleAgent.serverAddress in the values.yaml file." }}
{{- end }}
{{- end }}
2 changes: 1 addition & 1 deletion charts/rstudio-workbench/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: rstudio-workbench
description: Official Helm chart for Posit Workbench
version: 0.9.12
version: 0.9.13
apiVersion: v2
appVersion: 2025.09.0
icon: https://rstudio.com/wp-content/uploads/2018/10/RStudio-Logo-Flat.png
Expand Down
5 changes: 5 additions & 0 deletions charts/rstudio-workbench/NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 0.9.13

- Skip `rstudio-library` template call when `chronicleAgent.autoDiscovery=false`. Require `chronicleAgent.serverAddress`
to be set instead.

## 0.9.12

- Bump Workbench version to 2025.09.0
Expand Down
6 changes: 3 additions & 3 deletions charts/rstudio-workbench/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Posit Workbench

![Version: 0.9.12](https://img.shields.io/badge/Version-0.9.12-informational?style=flat-square) ![AppVersion: 2025.09.0](https://img.shields.io/badge/AppVersion-2025.09.0-informational?style=flat-square)
![Version: 0.9.13](https://img.shields.io/badge/Version-0.9.13-informational?style=flat-square) ![AppVersion: 2025.09.0](https://img.shields.io/badge/AppVersion-2025.09.0-informational?style=flat-square)

#### _Official Helm chart for Posit Workbench_

Expand All @@ -24,11 +24,11 @@ To ensure a stable production deployment:

## Installing the chart

To install the chart with the release name `my-release` at version 0.9.12:
To install the chart with the release name `my-release` at version 0.9.13:

```{.bash}
helm repo add rstudio https://helm.rstudio.com
helm upgrade --install my-release rstudio/rstudio-workbench --version=0.9.12
helm upgrade --install my-release rstudio/rstudio-workbench --version=0.9.13
```

To explore other chart versions, look at:
Expand Down
4 changes: 4 additions & 0 deletions charts/rstudio-workbench/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,11 @@ spec:
{{- end }}
env:
- name: CHRONICLE_SERVER_ADDRESS
{{- if .Values.chronicleAgent.autoDiscovery }}
value: {{ include "rstudio-library.chronicle-agent.serverAddress" (dict "chronicleAgent" .Values.chronicleAgent "Release" .Release) | trim | quote }}
{{- else }}
value: {{ required "chronicleAgent.serverAddress must be specified if autoDiscovery is disabled." .Values.chronicleAgent.serverAddress | quote }}
{{- end }}
- name: CHRONICLE_WORKBENCH_APIKEY
{{- if .Values.chronicleAgent.workbenchApiKey.valueFrom }}
valueFrom:
Expand Down