-
Notifications
You must be signed in to change notification settings - Fork 60
Rename action levels #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rename action levels #611
Conversation
Still working my way through this but just had a thought: Since the diffs are getting huge (due to find-and-replace), I think I'll revert those before I open this PR for review (which should only generate deprecation warnings in the checks), and then I can re-apply the name changes (which should resolve those deprecation warnings and put us back on track -- this can also be done in a separate PR to chunk things up). |
Summary
A TODO list for renaming action levels:
User-facing functions:
action_levels()
soft deprecation safeguardsaction_levels()
documentationwarn_on_fail()
error_on_fail(error)
to deprecatestop_on_fail(stop_at)
fns
(nowfns = action_fns(warn, error, critical)
Formalizing a<action_fns>
object #612 )action_fns()
(perhaps this PR can implement this internally and exporting can be separate PR)get_agent_x_list()
rename$stop
,$notify
Display/write:
<action_levels>
prints using new namesget_agent_report()
(report_tbl
)get_multiagent_report()
YAML:
Internals (low priority):
<action_levels>
object (ex:$stop_fraction
->$error_fraction
)agent$validation_set
(related toget_agent_x_list()
output)Documentation:
action_levels()
documentationFind-and-replace:
action_levels()
should use new names (ex: in "::QUIET::" agents for test/expect functions)Tests:
Related GitHub Issues and PRs
Checklist
testthat
unit tests totests/testthat
for any new functionality.