Skip to content

Conversation

@cderv
Copy link
Collaborator

@cderv cderv commented Dec 2, 2025

so that we can deploy to Connect Cloud

@yihui same logic

cderv added a commit that referenced this pull request Dec 2, 2025
so that we can deploy to Connect Cloud
@cderv cderv force-pushed the publish-connect-cloud branch from e8a40fb to b825030 Compare December 2, 2025 15:22
@cderv
Copy link
Collaborator Author

cderv commented Dec 2, 2025

It seems we have a webshot failure... 🤔

@cderv
Copy link
Collaborator Author

cderv commented Dec 2, 2025

Let's try to use webshot2

@cderv
Copy link
Collaborator Author

cderv commented Dec 2, 2025

@yihui I added you back here too

@cderv
Copy link
Collaborator Author

cderv commented Dec 2, 2025

Error in `as_pixels_int()`:
! `vwidth` must be an integer number of pixels, not '100%'.

Known error with webshot2 - we'll need to adapt

Thought I thought we handled it

@cderv
Copy link
Collaborator Author

cderv commented Dec 2, 2025

Oh this is not yet a release knitr version !!

cderv added 2 commits December 2, 2025 18:10
This is because we need yihui/knitr#2400
so install dev version from CI
@cderv cderv merged commit 61cdd32 into main Dec 2, 2025
1 check passed
@cderv cderv deleted the publish-connect-cloud branch December 2, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants