RB-409 Fixing Pipeline reset #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reseting only internal operators right after a single message comes out of the pipeline, the prior version was expecting to complete the input buffer execution although it is better to check on every iteration because only one message is required to produce output, so no need to wait for the whole input queue to be executed, the current behavior causes issues in cases where a resampler connected to the pipeline outputs more than one messages becuase a device restarted.
Like in the case of including a resampler inside the Pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reseting only internal operators right after a single message comes out of the pipeline, the prior version is expecting to complete the input buffer execution before checking for a posible output although it is better to check on every iteration given that only one message is required to produce output, so there is no need to wait for the whole input queue to be executed. The current behavior causes issues in cases where a resampler connected to the pipeline emits more than once due to the occasional restart of a device, so it upsamples.