Fix an autocorrection for FactoryBot/AssociationStyle cop when the trait is not a symbol literal
#157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trait is not a symbol literal Fixes: #105
pirj
reviewed
Oct 6, 2025
| end | ||
|
|
||
| def collect_trait_arguments(node) | ||
| node.arguments[1..].reject(&:hash_type?) |
There was a problem hiding this comment.
Will the ‘association’ accept the “last hash argument” in a variable or from a method call?
Won’t we attempt to use it as a trait?
Do we have a way to detect if it’s an options hash or a trait if it’s an lvar or a method call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #105
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).