Encapsulate mod.rs::validate_owner checks
#68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the code blocks in
p-token/src/entrypoint-runtime-verification.rschecking the validity of owner signatures as checked bymod.rs::validate_owner. In particular:inner_test_validate_ownerwhich contains the logic that was being checked in several tests.inner_test_validate_owner.multisig_is_initialised : Result<bool, ProgramError>tomaybe_multisig_is_initialised : Option<Result<bool, ProgramError>>so thatinner_test_validate_ownerdoesn't depend on themultisigconfig flag.Observation:
inner_test_validate_ownerhas the#[inline(always)]attribute. It is unclear to me if that should be the case.