[bitreq] Bitreq client builder

bitreq/examples/custom_cert.rs

@@ -0,0 +1,31 @@
+//! This example demonstrates the client builder with custom DER certificate.
+//! to run: cargo run --example custom_cert --features async-https-rustls
+
+#[cfg(feature = "async")]
+fn main() -> Result<(), bitreq::Error> {
+    let runtime = tokio::runtime::Builder::new_current_thread()
+        .enable_io()
+        .build()
+        .expect("failed to build Tokio runtime");
+
+    runtime.block_on(request_with_client())
+}
+
+async fn request_with_client() -> Result<(), bitreq::Error> {
+    let url = "http://example.com";
+    let cert_der = include_bytes!("../tests/test_cert.der");
+    let client = bitreq::Client::builder().with_root_certificate(cert_der.as_slice()).build();
+    // OR
+    // let cert_der: &[u8] = include_bytes!("../tests/test_cert.der");
+    // let client = bitreq::Client::builder().with_root_certificate(cert_der).build();
+    // OR
+    // let cert_vec: Vec<u8> = include_bytes!("../tests/test_cert.der").to_vec();
+    // let client = bitreq::Client::builder().with_root_certificate(cert_vec.as_slice()).build();
+
+    let response = client.send_async(bitreq::get(url)).await.unwrap();
+
+    println!("Status: {}", response.status_code);
+    println!("Body: {}", response.as_str()?);
+
+    Ok(())
+}

bitreq/src/client.rs

@@ -9,6 +9,7 @@
 use std::collections::{hash_map, HashMap, VecDeque};
 use std::sync::{Arc, Mutex};
 
+use crate::connection::certificates::Certificates;
 use crate::connection::AsyncConnection;
 use crate::request::{OwnedConnectionParams as ConnectionKey, ParsedRequest};
 use crate::{Error, Request, Response};
@@ -39,10 +40,140 @@ struct ClientImpl<T> {
     connections: HashMap<ConnectionKey, Arc<T>>,
     lru_order: VecDeque<ConnectionKey>,
     capacity: usize,
+    client_config: Option<ClientConfig>,
+}
+
+pub struct ClientBuilder {
+    capacity: usize,
+    client_config: Option<ClientConfig>,
+}
+
+#[derive(Clone)]
+pub(crate) struct ClientConfig {
+    pub(crate) tls: Option<TlsConfig>,
+}
+
+#[derive(Clone)]
+pub(crate) struct TlsConfig {
+    pub(crate) certificates: Certificates,
+}
+
+impl TlsConfig {
+    fn new(certificate: Vec<u8>) -> Self {
+        let certificates =
+            Certificates::new(Some(&certificate)).expect("failed to append certificate");
+
+        Self { certificates: certificates }
+    }
+}
+
+/// Builder for configuring a `Client` with custom settings.
+///
+/// The builder allows you to set the connection pool capacity and add
+/// custom root certificates for TLS verification before constructing the client.
+///
+/// # Example
+///
+/// ```no_run
+/// # async fn example() -> Result<(), bitreq::Error> {
+/// use bitreq::Client;
+///
+/// let cert_der = include_bytes!("../tests/test_cert.der");
+/// let client = Client::builder()
+///     .with_root_certificate(cert_der.as_slice())
+///     .with_capacity(20)
+///     .build();
+///
+/// let response = bitreq::get("https://example.com")
+///     .send_async_with_client(&client)
+///     .await?;
+/// # Ok(())
+/// # }
+/// ```
+impl ClientBuilder {
+    /// Creates a new `ClientBuilder` with default settings.
+    ///
+    /// Default configuration:
+    /// * `capacity` - 1 (single connection)
+    /// * `root_certificates` - None (uses system certificates)
+    pub fn new() -> Self {
+        Self { capacity: 1, client_config: None }
+    }
+
+    /// Adds a custom root certificate for TLS verification.
+    ///
+    /// The certificate must be provided in DER format. This method accepts any type
+    /// that can be converted into a `Vec<u8>`, such as `Vec<u8>`, `&[u8]`, or arrays.
+    /// This is useful when connecting to servers using self-signed certificates
+    /// or custom Certificate Authorities.
+    ///
+    /// # Arguments
+    ///
+    /// * `certificate` - A DER-encoded X.509 certificate. Accepts any type that implements
+    ///   `Into<Vec<u8>>` (e.g., `&[u8]`, `Vec<u8>`, or `[u8; N]`).
+    ///
+    /// # Example
+    ///
+    /// ```no_run
+    /// # use bitreq::Client;
+    /// // Using a byte slice
+    /// let cert_der: &[u8] = include_bytes!("../tests/test_cert.der");
+    /// let client = Client::builder()
+    ///     .with_root_certificate(cert_der)
+    ///     .build();
+    ///
+    /// // Using a Vec<u8>
+    /// let cert_vec: Vec<u8> = cert_der.to_vec();
+    /// let client = Client::builder()
+    ///     .with_root_certificate(cert_vec)
+    ///     .build();
+    /// ```
+    pub fn with_root_certificate<T: Into<Vec<u8>>>(mut self, certificate: T) -> Self {
+        let tls_config = TlsConfig::new(certificate.into());
+        self.client_config = Some(ClientConfig { tls: Some(tls_config) });
+        self
+    }
+
+    /// Sets the maximum number of connections to keep in the pool.
+    ///
+    /// When the pool reaches this capacity, the least recently used connection
+    /// is evicted to make room for new connections.
+    ///
+    /// # Arguments
+    ///
+    /// * `capacity` - Maximum number of cached connections
+    ///
+    /// # Example
+    ///
+    /// ```no_run
+    /// # use bitreq::Client;
+    /// let client = Client::builder()
+    ///     .with_capacity(10)
+    ///     .build();
+    /// ```
+    pub fn with_capacity(mut self, capacity: usize) -> Self {
+        self.capacity = capacity;
+        self
+    }
+
+    /// Builds the `Client` with the configured settings.
+    ///
+    /// Consumes the builder and returns a configured `Client` instance
+    /// ready to send requests with connection pooling.
+    pub fn build(self) -> Client {
+        Client {
+            r#async: Arc::new(Mutex::new(ClientImpl {
+                connections: HashMap::new(),
+                lru_order: VecDeque::new(),
+                capacity: self.capacity,
+                client_config: self.client_config,
+            })),
+        }
+    }
 }
 
 impl Client {
-    /// Creates a new `Client` with the specified connection cache capacity.
+    /// Creates a new `Client` with the specified connection pool capacity.
     ///
     /// # Arguments
     ///
@@ -54,10 +185,16 @@ impl Client {
                 connections: HashMap::new(),
                 lru_order: VecDeque::new(),
                 capacity,
+                client_config: None,
             })),
         }
     }
 
+    /// Create a builder for a client
+    pub fn builder() -> ClientBuilder {
+        ClientBuilder::new()
+    }
+
     /// Sends a request asynchronously using a cached connection if available.
     pub async fn send_async(&self, request: Request) -> Result<Response, Error> {
         let parsed_request = ParsedRequest::new(request)?;
@@ -77,7 +214,13 @@ impl Client {
         let conn = if let Some(conn) = conn_opt {
             conn
         } else {
-            let connection = AsyncConnection::new(key, parsed_request.timeout_at).await?;
+            let client_config = {
+                let state = self.r#async.lock().unwrap();
+                state.client_config.clone()
+            };
+
+            let connection =
+                AsyncConnection::new(key, parsed_request.timeout_at, client_config).await?;
             let connection = Arc::new(connection);
 
             let mut state = self.r#async.lock().unwrap();

bitreq/src/connection.rs

@@ -25,13 +25,17 @@ use tokio::sync::Mutex as AsyncMutex;
 use crate::request::{ConnectionParams, OwnedConnectionParams, ParsedRequest};
 #[cfg(feature = "async")]
 use crate::Response;
+#[cfg(feature = "async")]
+use crate::client::ClientConfig;
 use crate::{Error, Method, ResponseLazy};
 
 type UnsecuredStream = TcpStream;
 
 #[cfg(feature = "rustls")]
 mod rustls_stream;
 #[cfg(feature = "rustls")]
+pub(crate) mod certificates;
+#[cfg(feature = "rustls")]
 type SecuredStream = rustls_stream::SecuredStream;
 
 pub(crate) enum HttpStream {
@@ -266,15 +270,13 @@ impl AsyncConnection {
     pub(crate) async fn new(
         params: ConnectionParams<'_>,
         timeout_at: Option<Instant>,
+        client_config: Option<ClientConfig>,
     ) -> Result<AsyncConnection, Error> {
         let future = async move {
             let socket = Self::connect(params).await?;
 
             if params.https {
-                #[cfg(not(feature = "tokio-rustls"))]
-                return Err(Error::HttpsFeatureNotEnabled);
-                #[cfg(feature = "tokio-rustls")]
-                rustls_stream::wrap_async_stream(socket, params.host).await
+                Self::wrap_async_stream(socket, params.host, client_config).await
             } else {
                 Ok(AsyncHttpStream::Unsecured(socket))
             }
@@ -298,6 +300,27 @@ impl AsyncConnection {
         }))))
     }
 
+    /// Call the correct wrapper function depending on whether client_configs are present
+    #[cfg(all(feature = "rustls", feature = "tokio-rustls"))]
+    async fn wrap_async_stream(socket: AsyncTcpStream, host: &str, client_config: Option<ClientConfig>
+    ) -> Result<AsyncHttpStream, Error> {
+        if let Some(client_config) = client_config {
+            rustls_stream::wrap_async_stream_with_configs(socket, host, client_config).await
+        } else {
+            rustls_stream::wrap_async_stream(socket, host).await
+        }
+    }
+
+    /// Error treatment function, should not be called under normal circustances
+    #[cfg(not(all(feature = "rustls", feature = "tokio-rustls")))]
+    async fn wrap_async_stream(
+        _socket: AsyncTcpStream,
+        _host: &str,
+        _client_config: Option<ClientConfig>,
+    ) -> Result<AsyncHttpStream, Error> {
+        Err(Error::HttpsFeatureNotEnabled)
+    }
+
     async fn tcp_connect(host: &str, port: u16) -> Result<AsyncTcpStream, Error> {
         #[cfg(feature = "log")]
         log::trace!("Looking up host {host}");
@@ -447,7 +470,7 @@ impl AsyncConnection {
                 };
                 (_internal) => {
                     let new_connection =
-                        AsyncConnection::new(request.connection_params(), request.timeout_at)
+                        AsyncConnection::new(request.connection_params(), request.timeout_at, None)
                             .await?;
                     *self.0.lock().unwrap() = Arc::clone(&*new_connection.0.lock().unwrap());
                     core::mem::drop(read);
@@ -806,7 +829,7 @@ async fn async_handle_redirects(
             let new_connection;
             if needs_new_connection {
                 new_connection =
-                    AsyncConnection::new(request.connection_params(), request.timeout_at).await?;
+                    AsyncConnection::new(request.connection_params(), request.timeout_at, None).await?;
                 connection = &new_connection;
             }
             connection.send(request).await

bitreq/src/connection/certificates.rs

@@ -0,0 +1,64 @@
+#[cfg(feature = "rustls")]
+use rustls::RootCertStore;
+#[cfg(feature = "rustls-webpki")]
+use webpki_roots::TLS_SERVER_ROOTS;
+
+use crate::Error;
+
+#[derive(Clone)]
+pub(crate) struct Certificates {
+    pub(crate) inner: RootCertStore,
+}
+
+impl Certificates {
+    pub(crate) fn new(certificate: Option<&Vec<u8>>) -> Result<Self, Error> {
+        let certificates = Self { inner: RootCertStore::empty() };
+
+        let result = if let Some(certificate) = certificate {
+            certificates.append_certificate(certificate)
+        } else {
+            Ok(certificates)
+        };
+        result
+    }
+
+    #[cfg(feature = "rustls")]
+    pub(crate) fn append_certificate(mut self, certificate: &Vec<u8>) -> Result<Self, Error> {
+        let mut certificates = self.inner;
+        certificates
+            .add(&rustls::Certificate(certificate.clone()))
+            .map_err(Error::RustlsAppendCert)?;
+        self.inner = certificates;
+        Ok(self)
+    }
+
+    #[cfg(feature = "rustls")]
+    pub(crate) fn with_root_certificates(mut self) -> Self {
+        let mut root_certificates = self.inner;
+
+        // Try to load native certs
+        #[cfg(feature = "https-rustls-probe")]
+        if let Ok(os_roots) = rustls_native_certs::load_native_certs() {
+            for root_cert in os_roots {
+                // Ignore erroneous OS certificates, there's nothing
+                // to do differently in that situation anyways.
+                let _ = root_certificates.add(&rustls::Certificate(root_cert.0));
+            }
+        }
+
+        #[cfg(feature = "rustls-webpki")]
+        {
+            #[allow(deprecated)]
+            // Need to use add_server_trust_anchors to compile with rustls 0.21.1
+            root_certificates.add_server_trust_anchors(TLS_SERVER_ROOTS.iter().map(|ta| {
+                rustls::OwnedTrustAnchor::from_subject_spki_name_constraints(
+                    ta.subject,
+                    ta.spki,
+                    ta.name_constraints,
+                )
+            }));
+        }
+        self.inner = root_certificates;
+        self
+    }
+}