Skip to content

cargo build diagnostic improvements #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

cargo build diagnostic improvements #154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9589698
enable colored output from `cargo build`
antonok-edm Mar 27, 2025
c65575e
show build diagnostics even if build fails
antonok-edm Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ fn cargo_build(matches: &ArgMatches, metadata: &Metadata) -> Result<Option<Artif
let (build_type, verbose) = cargo_build_args(matches, &mut cargo);
let quiet = matches.get_flag("quiet");

cargo.arg("--message-format=json");
cargo.arg("--message-format=json-diagnostic-rendered-ansi");
cargo.stdout(Stdio::piped());

if verbose > 0 {
Expand All @@ -428,9 +428,6 @@ fn cargo_build(matches: &ArgMatches, metadata: &Metadata) -> Result<Option<Artif
let messages = Message::parse_stream(stdout).collect::<Vec<_>>();

let status = child.wait()?;
if !status.success() {
bail!("Failed to parse crate metadata");
}

let mut target_artifact: Option<Artifact> = None;
for message in messages {
Expand All @@ -457,6 +454,10 @@ fn cargo_build(matches: &ArgMatches, metadata: &Metadata) -> Result<Option<Artif
}
}

if !status.success() {
bail!("Failed to parse crate metadata");
}

if target_artifact.is_none() {
bail!("Could not determine the wanted artifact");
}
Expand Down