Skip to content

Conversation

@YuhanLiin
Copy link

The CapturePin trait is the input capture analogue to the PwmPin trait, representing a single capture channel. Unlike PwmPin, there's no enable or disable methods, because some chips, such as the MSP430FR2355, may have trouble implementing those two methods on capture abstractions. The proposed trait has been implemented in msp430fr2x5x-hal.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@YuhanLiin
Copy link
Author

The proposal for the trait is here, which I added after reading that I need to complete a proposal before opening a PR to add a new trait.

@YuhanLiin YuhanLiin requested a review from ryankurte March 29, 2020 13:10
@YuhanLiin
Copy link
Author

Any updates on this?

@eldruin
Copy link
Member

eldruin commented Nov 11, 2022

I would say let's reevaluate this after the 1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants