Skip to content

Make ADC Channel trait use a stateful method to get the IDs #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2020
Merged

Make ADC Channel trait use a stateful method to get the IDs #242

merged 1 commit into from
Aug 31, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Aug 4, 2020

Closes #110

@eldruin eldruin requested review from ilya-epifanov and a team as code owners August 4, 2020 21:09
@rust-highfive
Copy link

r? @therealprof

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Review is incomplete T-hal labels Aug 4, 2020
@eldruin eldruin added this to the v1.0.0 milestone Aug 4, 2020
@eldruin eldruin mentioned this pull request Aug 4, 2020
Closed
david-sawatzke
david-sawatzke reviewed Aug 5, 2020
View reviewed changes
@eldruin
Copy link
Member Author

eldruin commented Aug 5, 2020

As highlighted by @david-sawatzke, with this PR we do not need Rust 1.35. anymore.
Should we decrease the MSRV back to 1.31?
What do you think @rust-embedded/hal?

@therealprof
Copy link
Contributor

I'd rather not. We're already very conservative with our MSRV and that seems like a rather pointless change, in that it will create work which at best has a temporary use (i.e. until we have to bump the MSRV for something else) and no one so far has complained about 1.35 being a problem to begin with.

@eldruin
Copy link
Member Author

eldruin commented Aug 5, 2020

Alright, I was also thinking along those lines.

@Rahix Rahix mentioned this pull request Aug 5, 2020
Open
ryankurte
ryankurte approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @therealprof anything outstanding?

therealprof
therealprof approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too.

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 31, 2020

Build succeeded:

@bors bors bot merged commit 6167156 into rust-embedded:master Aug 31, 2020
@eldruin eldruin deleted the adc-channel-method branch August 31, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankurte ryankurte ryankurte approved these changes

@therealprof therealprof therealprof approved these changes

@ilya-epifanov ilya-epifanov Awaiting requested review from ilya-epifanov

+1 more reviewer

@david-sawatzke david-sawatzke david-sawatzke left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@therealprof therealprof

Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

ADC API does not allow non-unit channels
5 participants
@eldruin @rust-highfive @therealprof @ryankurte @david-sawatzke