Fully migrate to defmt 1.x #716
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainstorm
force-pushed
the
defmt_1.x
branch
from
de78350 to
00c7cd4
Compare
Member
|
Renaming the feature (actually upgrading 0.3 -> 1.0 is not a breaking change since defmt 0.3.99 reexports 1.0 so they're compatible) |
Dirbaio
reviewed
Nov 27, 2025
| #[cfg(feature = "defmt-03")] | ||
| use defmt_03 as defmt; | ||
| #[cfg(feature = "defmt")] | ||
| use defmt; |
Member
There was a problem hiding this comment.
this is not needed now that we're not renaming the dep anymore. (here and in other files either as use defmt or use crate::defmt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: embassy-rs/embassy#4957
(and tangentially to mkj/sunset#38)