Skip to content

Conversation

@ernstp-se
Copy link
Contributor

Don't evaluate this inside a function definition.
Fixes issues with "metadata is not deterministic".

Fixes #195

Don't evaluate this inside a function definition.
Fixes issues with "metadata is not deterministic".

Fixes rust-embedded#195
@ernstp-se
Copy link
Contributor Author

Not 100% why this works, but I have tested it quite a lot. Mostly tested on Scarthgap so far.

@ernstp-se
Copy link
Contributor Author

ping @eldruin @posborne

Copy link
Contributor

@wdouglass wdouglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have solved metadata mismatch issues for me as well. Please consider merging.

Edit: I tested this on kirkstone.

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for testing this. Let's merge it then.

@eldruin eldruin merged commit b5fe3f0 into rust-embedded:master Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New "metadata is not deterministic" issues

3 participants