Fix cc wrappers (revert #197) #210
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm not mistaken, the changes made in pull request #197 break some rust build scripts.
The behavior as it originally was should have been correct, as it defines
According to the
ccdocs,TARGET_CCtakes precedence overCCwhen cross-compiling to the target, and otherwiseCCis being used.In addition, the original pull request defined the variable
BUILD_CC, but that is meaningless for thecccrate (Yocto defines such a variable, butcconly looks forHOST_CCandCCwhen compiling for the host).I think this should also fix #204
I'm not sure what the original problem was which pull request #197 tried to solve, but maybe there was just no adequate
gccinstalled on the host system?