Skip to content

Conversation

romancardenas
Copy link
Contributor

Closes #339

Closes #239 (no longer needed for ESP32 crates)

@romancardenas romancardenas requested a review from a team as a code owner September 3, 2025 19:44
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer and not familiar with the release process here but this looks good to me.

Looking forward to the new release

Copy link
Contributor

@rmsyn rmsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small clarifying question about the version bump in riscv-semihosting, otherwise LGTM.

@@ -12,7 +12,7 @@ license = "MIT OR Apache-2.0"
name = "riscv-semihosting"
readme = "README.md"
repository = "https://github.com/riscv-rust/riscv"
version = "0.2.0"
version = "0.2.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit: since this update includes a minor version bump in the riscv dependency, would that also justify a minor version bump in riscv-semihosting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As different versions of riscv can coexist, and upgrading riscv to v0.15 does not modify how riscv-semihosting works, I think a minor bump is not necessary. In riscv-peripheral, as we are getting rid of a reexport, a minor bump is required.

Maybe I'm wrong and it's better to bump riscv-semhosting to v0.3.0 too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the only place riscv is used inside riscv-semihosting is in the Cargo.toml. Am I missing something? Seems the dependency could be dropped altogether.

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New releases riscv-rt: reconfigurable trap frame
4 participants