-
Notifications
You must be signed in to change notification settings - Fork 182
Prepare for new riscv
releases
#340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a maintainer and not familiar with the release process here but this looks good to me.
Looking forward to the new release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small clarifying question about the version bump in riscv-semihosting
, otherwise LGTM.
@@ -12,7 +12,7 @@ license = "MIT OR Apache-2.0" | |||
name = "riscv-semihosting" | |||
readme = "README.md" | |||
repository = "https://github.com/riscv-rust/riscv" | |||
version = "0.2.0" | |||
version = "0.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit: since this update includes a minor version bump in the riscv
dependency, would that also justify a minor version bump in riscv-semihosting
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As different versions of riscv
can coexist, and upgrading riscv
to v0.15 does not modify how riscv-semihosting
works, I think a minor bump is not necessary. In riscv-peripheral
, as we are getting rid of a reexport, a minor bump is required.
Maybe I'm wrong and it's better to bump riscv-semhosting
to v0.3.0 too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the only place riscv
is used inside riscv-semihosting
is in the Cargo.toml
. Am I missing something? Seems the dependency could be dropped altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Closes #339
Closes #239 (no longer needed for ESP32 crates)